Bugzilla – Attachment 121211 Details for
Bug 28171
Serial enumeration / chronology sorting is broken in biblio page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28171: Restore previous sorting behaviour for Serial enumchron column
Bug-28171-Restore-previous-sorting-behaviour-for-S.patch (text/plain), 2.57 KB, created by
PTFS Europe Sandboxes
on 2021-05-20 06:55:24 UTC
(
hide
)
Description:
Bug 28171: Restore previous sorting behaviour for Serial enumchron column
Filename:
MIME Type:
Creator:
PTFS Europe Sandboxes
Created:
2021-05-20 06:55:24 UTC
Size:
2.57 KB
patch
obsolete
>From 3b682cb65f98ce21fa52a90dd3d35fac9361d815 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Wed, 21 Apr 2021 19:19:07 +0300 >Subject: [PATCH] Bug 28171: Restore previous sorting behaviour for Serial > enumchron column > >Before Bug 27980 the sorting was done either by item's publisheddate >if it existed in at least one item. If it didn't exist then the >sorting was done using "h - Serial Enumeration / chronology" >field. This restores this sorting functionality in catalogue/detail.pl >page. > >To test: > 1. Create a serial subscription for a biblio, make sure to enable the > option "Create an item record when receiving this serial" > 2. Receive two serials, so that they have different received dates > and check that the items are now created to the biblio > 3. Add now two additional items with one having "A" and other having > "B" in the "h - Serial Enumeration / chronology" field. > 4. Try sorting and notice the items with publisheddate are being > sorted and ones without stay in the order they happened to be > 5. Remove the items with publisheddate and notice that now items with > "A" and "B" get sorted correctly > >Signed-off-by: cnelson <christian.nelson@tritonia.fi> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index bde528c30d..9cc56af50a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -394,7 +394,11 @@ Note that permanent location is a code, and location may be an authval. > [% IF ( itemdata_ccode ) %]<td>[% item.ccode | html %]</td>[% END %] > <td class="itemcallnumber">[% IF ( item.itemcallnumber ) %] [% item.itemcallnumber | html %][% END %]</td> > [% IF ( volinfo ) %] >- <td class="enumchron" data-order="[% item.publisheddate | html %]"> >+ [% IF ( itemdata_publisheddate ) %] >+ <td class="enumchron" data-order="[% item.publisheddate | html %]"> >+ [% ELSE %] >+ <td class="enumchron"> >+ [% END %] > [% IF ( itemdata_enumchron ) %] > [% IF item.enumchron && item.serialseq %] > <span class="enum">[% item.enumchron | html %]</span> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28171
:
119869
|
119896
|
119960
|
119961
|
121210
|
121211
|
121212
|
121213
|
121214
|
121215
|
121483
|
121484
|
121593