Attachment 121239 Details for Bug 15067 – Bug 15067: Follow up to fix sorting

[patch] Bug 15067: Follow up to fix sorting

Bug-15067-Follow-up-to-fix-sorting.patch (text/plain), 1.11 KB, created by Matthias Meusburger on 2021-05-20 12:56:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Meusburger

Created: 2021-05-20 12:56:45 UTC

Size: 1.11 KB

patch

obsolete

>From 8d049442a650816f2b8c5a1007b1c541d49ca766 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 25 Jan 2016 20:47:27 +0000
>Subject: [PATCH] Bug 15067: Follow up to fix sorting
>
>It looks like C4::Languages:getLanguages relies on implicit database
>order for languages. They appear to be sorted by subtag so this patch
>adds that sorting to the database query to ensure the dropdown is
>sorted.
>
>Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
>---
> C4/Languages.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Languages.pm b/C4/Languages.pm
>index 8042bcd..5550b0f 100644
>--- a/C4/Languages.pm
>+++ b/C4/Languages.pm
>@@ -199,7 +199,7 @@ sub getLanguages {
>     if ($lang) {
>         $current_language = regex_lang_subtags($lang)->{'language'};
>     }
>-    my $sth = $dbh->prepare('SELECT * FROM language_subtag_registry WHERE type=\'language\'');
>+    my $sth = $dbh->prepare('SELECT * FROM language_subtag_registry WHERE type=\'language\' ORDER BY description');
>     $sth->execute();
>     while (my $language_subtag_registry = $sth->fetchrow_hashref) {
>         my $desc;
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 15067: 47076 | 47279 | 47280 | 47285 | 47286 | 47287 | 84122 | 84124 | 86122 | 89642 | 121239 | 121240 | 121241 | 121260 | 121261 | 121262 | 123140 | 123141 | 123142 | 123143 | 128105 | 128112