Attachment 12127 Details for Bug 8757 – proposed patch

[patch] proposed patch

0001-Bug-8757-longer-descriptions-for-authorised-values.patch (text/plain), 3.45 KB, created by Adrien SAURAT on 2012-09-11 09:18:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adrien SAURAT

Created: 2012-09-11 09:18:46 UTC

Size: 3.45 KB

patch

obsolete

>From 8357b874c9ab35890a613967a4b588adb58b9e9d Mon Sep 17 00:00:00 2001
>From: Adrien Saurat <adrien.saurat@biblibre.com>
>Date: Tue, 11 Sep 2012 11:16:29 +0200
>Subject: [PATCH] Bug 8757: longer descriptions for authorised values
>
>In the "suggestions" table, the "lib" and "lib_opac" sizes
>has been raised from 80 chars to 200.
>The GUI allowing the authorised values creation/update has
>been changed accordingly.
>---
> installer/data/mysql/kohastructure.sql             |    4 ++--
> installer/data/mysql/updatedatabase.pl             |    9 +++++++++
> .../prog/en/modules/admin/authorised_values.tt     |    4 ++--
> 3 files changed, 13 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 91d42a2..f72086e 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -99,8 +99,8 @@ CREATE TABLE `authorised_values` ( -- stores values for authorized values catego
>   `id` int(11) NOT NULL auto_increment, -- unique key, used to identify the authorized value
>   `category` varchar(10) NOT NULL default '', -- key used to identify the authorized value category
>   `authorised_value` varchar(80) NOT NULL default '', -- code use to identify the authorized value
>-  `lib` varchar(80) default NULL, -- authorized value description as printed in the staff client
>-  `lib_opac` VARCHAR(80) default NULL, -- authorized value description as printed in the OPAC
>+  `lib` varchar(200) default NULL, -- authorized value description as printed in the staff client
>+  `lib_opac` varchar(200) default NULL, -- authorized value description as printed in the OPAC
>   `imageurl` varchar(200) default NULL, -- authorized value URL
>   PRIMARY KEY  (`id`),
>   KEY `name` (`category`),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 25cd367..d711d4f 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -5696,6 +5696,15 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
>     SetVersion($DBversion);
> }
> 
>+$DBversion = "3.09.00.XXX";
>+if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
>+    $dbh->do("ALTER TABLE authorised_values MODIFY lib varchar(200)");
>+    $dbh->do("ALTER TABLE authorised_values MODIFY lib_opac varchar(200)");
>+
>+    print "Upgrade to $DBversion done (Raise the length of Authorised Values descriptions)\n";
>+    SetVersion($DBversion);
>+}
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>index 3af0724..4acaac3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>@@ -72,11 +72,11 @@
>         </li>
>         <li>
>             <label for="lib">Description</label>
>-            <input type="text" name="lib" id="lib" value="[% lib %]" maxlength="80" />
>+            <input type="text" name="lib" id="lib" value="[% lib %]" maxlength="200" />
>         </li>
> 	<li>
>             <label for="lib_opac">Description (OPAC)</label>
>-            <input type="text" name="lib_opac" id="lib_opac" value="[% lib_opac %]" maxlength="80" />
>+            <input type="text" name="lib_opac" id="lib_opac" value="[% lib_opac %]" maxlength="200" />
>         </li>
> 		</ol>
>         <div id="icons" class="toptabs" style="clear:both">
>-- 
>1.7.9.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 8757: 12127 | 12162