Attachment 121300 Details for Bug 17656 – Bug 17656: QA warnings fixes

[patch] Bug 17656: QA warnings fixes

Bug-17656-QA-warnings-fixes.patch (text/plain), 2.66 KB, created by Victor Grousset/tuxayo on 2021-05-23 20:35:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2021-05-23 20:35:23 UTC

Size: 2.66 KB

patch

obsolete

>From 97b4278c3ffcf8d494de65ecf656d4a65b0f5a22 Mon Sep 17 00:00:00 2001
>From: Alex Arnaud <alex.arnaud@biblibre.com>
>Date: Fri, 5 Mar 2021 14:22:53 +0100
>Subject: [PATCH] Bug 17656: QA warnings fixes
>
>Signed-off-by: Amarangi  <amarangikarunathilaka@gmail.com>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> Koha/Subscription.pm                              | 5 ++---
> t/Serials/IssueNumber.t                           | 0
> t/db_dependent/Koha/Subscription/GuessEnddate.t   | 0
> t/db_dependent/Koha/Subscription/Irregularities.t | 0
> t/db_dependent/Serials/SubscriptionIrregularity.t | 0
> 5 files changed, 2 insertions(+), 3 deletions(-)
> mode change 100644 => 100755 t/Serials/IssueNumber.t
> mode change 100644 => 100755 t/db_dependent/Koha/Subscription/GuessEnddate.t
> mode change 100644 => 100755 t/db_dependent/Koha/Subscription/Irregularities.t
> mode change 100644 => 100755 t/db_dependent/Serials/SubscriptionIrregularity.t
>
>diff --git a/Koha/Subscription.pm b/Koha/Subscription.pm
>index 39a3da2a8c..7b5e580191 100644
>--- a/Koha/Subscription.pm
>+++ b/Koha/Subscription.pm
>@@ -22,7 +22,6 @@ use Modern::Perl;
> use Carp;
> 
> use C4::Serials::Frequency;
>-use C4::Serials qw(issue_number);
> 
> use Koha::Database;
> use Koha::Biblios;
>@@ -268,7 +267,7 @@ sub guess_irregularities {
>     my $date = $nextexpected->{planneddate};
> 
>     my ($issuenumber) = C4::Serials::GetFictiveIssueNumber($self->unblessed, $date);
>-    my $dow = issue_number( dt_from_string($date), $frequency->unit );
>+    my $dow = C4::Serials::issue_number( dt_from_string($date), $frequency->unit );
> 
>     if ( defined( $permanent_irregularities{$dow} ) ) {
>         push @irregularities, $issuenumber;
>@@ -277,7 +276,7 @@ sub guess_irregularities {
>     while ( Delta_Days( split(/-/, $date), split(/-/, $enddate) ) >= 0 ) {
>         $issuenumber++;
>         $date = C4::Serials::GetNextDate($self->unblessed, $date);
>-        $dow = issue_number( dt_from_string($date), $frequency->unit );
>+        $dow = C4::Serials::issue_number( dt_from_string($date), $frequency->unit );
> 
>         if ( defined( $permanent_irregularities{$dow} ) ) {
>             push @irregularities, $issuenumber;
>diff --git a/t/Serials/IssueNumber.t b/t/Serials/IssueNumber.t
>old mode 100644
>new mode 100755
>diff --git a/t/db_dependent/Koha/Subscription/GuessEnddate.t b/t/db_dependent/Koha/Subscription/GuessEnddate.t
>old mode 100644
>new mode 100755
>diff --git a/t/db_dependent/Koha/Subscription/Irregularities.t b/t/db_dependent/Koha/Subscription/Irregularities.t
>old mode 100644
>new mode 100755
>diff --git a/t/db_dependent/Serials/SubscriptionIrregularity.t b/t/db_dependent/Serials/SubscriptionIrregularity.t
>old mode 100644
>new mode 100755
>-- 
>2.31.1

Actions: View | Diff | Splinter Review

Attachments on bug 17656: 68259 | 68261 | 68607 | 68608 | 68665 | 69124 | 69207 | 69279 | 69553 | 69814 | 69820 | 69915 | 70335 | 70336 | 70430 | 70619 | 75403 | 75404 | 75405 | 75406 | 75407 | 75408 | 75721 | 75722 | 75723 | 75724 | 75725 | 75726 | 75953 | 102724 | 102725 | 102726 | 102727 | 102728 | 102729 | 102730 | 102860 | 102861 | 102862 | 102863 | 102864 | 102865 | 102866 | 102867 | 102960 | 102961 | 102962 | 102963 | 102964 | 102965 | 102966 | 102967 | 102968 | 103623 | 103624 | 103625 | 103626 | 103627 | 103628 | 103629 | 103630 | 103631 | 103657 | 103658 | 103659 | 103660 | 103661 | 103662 | 103663 | 103664 | 103665 | 103667 | 117789 | 117790 | 117791 | 117792 | 117846 | 117851 | 117852 | 118856 | 119106 | 120863 | 121082 | 121083 | 121084 | 121085 | 121086 | 121087 | 121088 | 121192 | 121193 | 121194 | 121195 | 121196 | 121197 | 121198 | 121296 | 121297 | 121298 | 121299 | 121300 | 121301 | 121302 | 128489 | 128491 | 128492 | 128493 | 128494 | 128495 | 128496 | 128498 | 128499 | 128500 | 128501 | 128502 | 128503 | 128504 | 132412 | 132413 | 132415 | 132416 | 132417 | 132418 | 132447 | 132448 | 132692 | 132779