Attachment 121304 Details for Bug 28424 – Bug 28424: Regression tests

[patch] Bug 28424: Regression tests

Bug-28424-Regression-tests.patch (text/plain), 2.69 KB, created by David Nind on 2021-05-23 21:05:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-05-23 21:05:17 UTC

Size: 2.69 KB

patch

obsolete

>From abc68c4d05de23eee8ceebd05e0a1ba09715aa52 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 21 May 2021 18:22:44 -0300
>Subject: [PATCH] Bug 28424: Regression tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/api/v1/patrons_accounts.t | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/patrons_accounts.t b/t/db_dependent/api/v1/patrons_accounts.t
>index fd7ab48afb..68ca9386eb 100755
>--- a/t/db_dependent/api/v1/patrons_accounts.t
>+++ b/t/db_dependent/api/v1/patrons_accounts.t
>@@ -210,9 +210,10 @@ subtest 'add_credit() tests' => sub {
> 
>     my $credit = { amount => 100 };
> 
>-    $t->post_ok("//$userid:$password@/api/v1/patrons/$patron_id/account/credits" => json => $credit)
>-      ->status_is(200)
>-      ->json_has('/account_line_id');
>+    my $ret = $t->post_ok("//$userid:$password@/api/v1/patrons/$patron_id/account/credits" => json => $credit)
>+      ->status_is(201)->tx->res->json;
>+
>+    is_deeply( $ret, Koha::Account::Lines->find( $ret->{account_line_id} )->to_api, 'Line returned correctly' );
> 
>     my $outstanding_credits = $account->outstanding_credits;
>     is( $outstanding_credits->count,             1 );
>@@ -244,9 +245,11 @@ subtest 'add_credit() tests' => sub {
>     is( $account->outstanding_debits->total_outstanding, 25 );
>     $credit->{library_id} = $library->id;
> 
>-    $t->post_ok("//$userid:$password@/api/v1/patrons/$patron_id/account/credits" => json => $credit)
>-      ->status_is(200)
>-      ->json_has('/account_line_id');
>+    $ret = $t->post_ok("//$userid:$password@/api/v1/patrons/$patron_id/account/credits" => json => $credit)
>+      ->status_is(201)
>+      ->tx->res->json;
>+
>+    is_deeply( $ret, Koha::Account::Lines->find( $ret->{account_line_id} )->to_api, 'Line returned correctly' );
> 
>     my $account_line_id = $t->tx->res->json->{account_line_id};
>     is( Koha::Account::Lines->find($account_line_id)->branchcode,
>@@ -272,9 +275,11 @@ subtest 'add_credit() tests' => sub {
>         account_lines_ids => [ $debit_1->id, $debit_2->id, $debit_3->id ]
>     };
> 
>-    $t->post_ok("//$userid:$password@/api/v1/patrons/$patron_id/account/credits" => json => $credit)
>-      ->status_is(200)
>-      ->json_has('/account_line_id');
>+    $ret = $t->post_ok("//$userid:$password@/api/v1/patrons/$patron_id/account/credits" => json => $credit)
>+      ->status_is(201)
>+      ->tx->res->json;
>+
>+    is_deeply( $ret, Koha::Account::Lines->find( $ret->{account_line_id} )->to_api, 'Line returned correctly' );
> 
>     my $outstanding_debits = $account->outstanding_debits;
>     is( $outstanding_debits->total_outstanding, 65 );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28424: 121292 | 121293 | 121294 | 121295 | 121304 | 121305 | 121306 | 121307