Attachment 121327 Details for Bug 28423 – Bug 28423: JavaScript error on MARC modifications page

[patch] Bug 28423: JavaScript error on MARC modifications page

Bug-28423-JavaScript-error-on-MARC-modifications-p.patch (text/plain), 1.68 KB, created by Katrin Fischer on 2021-05-24 13:27:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-05-24 13:27:50 UTC

Size: 1.68 KB

patch

obsolete

>From d6cdedce4aed9859ed71ae1d187c7b0bbdd67696 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 21 May 2021 17:11:09 +0000
>Subject: [PATCH] Bug 28423: JavaScript error on MARC modifications page
>
>This patch makes a minor change to the MARC modifications template so
>that the "mmtas" variable isn't defined if there is no JSON to be
>assigned as its value.
>
>To test, apply the patch and go to Administration -> MARC modification
>templates.
>
> - If necessary, add a template with at least one action.
> - Check the browser console, there should be no errors.
> - Click the "Edit" button corresponding to one of the template actions.
> - The details of the action should load correctly in the edit form and
>   there should be no errors in the console.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/tools/marc_modification_templates.tt              | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
>index f8698b28a0..6459266260 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
>@@ -354,7 +354,9 @@
>     [% Asset.js("js/tools-menu.js") | $raw %]
>     [% Asset.js("js/marc_modification_templates.js") | $raw %]
>     <script>
>-        var mmtas = [% ActionsLoop.json | $raw %]
>+        [% IF ActionsLoop %]
>+            var mmtas = [% ActionsLoop.json | $raw %]
>+        [% END %]
>     </script>
> [% END %]
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28423: 121280 | 121303 | 121327