Attachment 121336 Details for Bug 28204 – Bug 28204: Fix table highlighting

[patch] Bug 28204: Fix table highlighting

Bug-28204-Fix-table-highlighting.patch (text/plain), 2.03 KB, created by Katrin Fischer on 2021-05-24 14:12:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-05-24 14:12:44 UTC

Size: 2.03 KB

patch

obsolete

>From c91247dd73d83b80a6b74ce6a7b7950c8746cb08 Mon Sep 17 00:00:00 2001
>From: Petro Vashchuk <stalkernoid@gmail.com>
>Date: Thu, 20 May 2021 16:12:18 +0300
>Subject: [PATCH] Bug 28204: Fix table highlighting
>
>Fix table highlighting at
>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX
>Every odd row of the table didn't get highlighted with the yellow color
>when you tried to edit it previously, this patch fixes that.
>That happened because every odd row had different coloring style that
>was overwriting yellow highlight.
>
>How to reproduce:
>1) Head over to the
>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX,
>where XXXX is id of some bilbio record that has more than one
>biblio item.
>2) Press the "Action" button of the first (or any other odd numbered)
>biblion item, and from the dropdown menu select "edit" option.
>3) Notice that it doesn't highlight it with yellow color.
>4) Now do the same but with second biblio item (or any even numbered
>item).
>5) Notice that it highlights it with the yellow color.
>6) Apply the patch. Do yarn build to compile css.
>7) Make sure that every row of the table that you edit gets properly
>highlighted with the yellow color.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss
>index b67f7f9268..44e2b32ae4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss
>@@ -334,6 +334,10 @@ tbody {
>         &:nth-child(odd):not(.dtrg-group) {
>             td {
>                 border-right: 1px solid $table-border-color;
>+            }
>+        }
>+        &:nth-child(odd):not(.dtrg-group):not(.active) {
>+            td {
>                 &:not(.bg-danger):not(.bg-warning):not(.bg-info):not(.bg-success):not(.bg-primary) {
>                     background-color: $table-odd-row;
>                 }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28204: 120092 | 121242 | 121333 | 121334 | 121335 | 121336 | 121626