Bugzilla – Attachment 121366 Details for
Bug 28158
Lost items not charging when marked lost from batch item modification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28158: [alternate] Use try/catch instead of eval
Bug-28158-alternate-Use-trycatch-instead-of-eval.patch (text/plain), 1.48 KB, created by
Nick Clemens (kidclamp)
on 2021-05-25 10:00:19 UTC
(
hide
)
Description:
Bug 28158: [alternate] Use try/catch instead of eval
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-05-25 10:00:19 UTC
Size:
1.48 KB
patch
obsolete
>From 12832883e17a30b659d24dadaa42c36fe1e8c94a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 25 May 2021 09:59:07 +0000 >Subject: [PATCH] Bug 28158: [alternate] Use try/catch instead of eval > >This could be improved, we could actually handle any exceptions, >but switching to 'try/catch' seems to resolve the issue >--- > tools/batchMod.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index b36752c77d..ae1a97ec36 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -298,7 +298,7 @@ if ($op eq "action") { > > $modified += UpdateMarcWith( $marcitem, $localmarcitem ); > if ($modified) { >- eval { >+ try { > if ( > my $item = ModItemFromMarc( > $localmarcitem, >@@ -316,7 +316,7 @@ if ($op eq "action") { > ) if $item->{itemlost} > and not $itemdata->{itemlost}; > } >- }; >+ } catch {}; > push @$upd_biblionumbers, $itemdata->{'biblionumber'}; > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28158
:
121340
|
121345
|
121352
|
121353
|
121366
|
121367
|
121368
|
121369
|
121415
|
121416
|
121417