Bugzilla – Attachment 121390 Details for
Bug 28452
Add managing librarian to transaction page (boraccount.pl)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28452: add Managed by column to boraccount.tt
Bug-28452-add-Managed-by-column-to-boraccounttt.patch (text/plain), 3.16 KB, created by
Lucas Gass (lukeg)
on 2021-05-25 15:30:30 UTC
(
hide
)
Description:
Bug 28452: add Managed by column to boraccount.tt
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2021-05-25 15:30:30 UTC
Size:
3.16 KB
patch
obsolete
>From f8090d2269ab2a9cadd2ed51ce2ec0df4d8605e9 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 25 May 2021 15:26:02 +0000 >Subject: [PATCH] Bug 28452: add Managed by column to boraccount.tt > >To test: >-Do some transactions on boraccount.tt. Payments, write-offs.. >-Check the transaction tab at boraccount.tt >-No info about the librian who did this action >-Apply patch >-Try doing some more transactions >-You should now see the first and last name of the librarian who accepted the payments/did the transactions >--- > admin/columns_settings.yml | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 4 +++- > members/boraccount.pl | 2 ++ > 3 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index a4986652b6..60b518fa0d 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -683,6 +683,10 @@ modules: > - > columnname: date > - >+ columnname: updated_on >+ - >+ columnname: manager >+ - > columnname: credit_number > is_hidden: 1 > - >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index fd4484aeaa..bc47b53d21 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -62,6 +62,7 @@ > <tr> > <th>Created</th> > <th>Updated</th> >+ <th>Managed by</th> > <th>Credit number</th> > <th>Account type</th> > <th>Description of charges</th> >@@ -84,6 +85,7 @@ > <tr> > <td data-order="[% account.date | html %]">[% account.date | $KohaDates %]</td> > <td data-order="[% account.timestamp | html %]">[% account.timestamp | $KohaDates with_hours = 1 %]</td> >+ <td>[% loggedinuser.surname | html %], [% loggedinuser.firstname | html %]</td> > <td>[% account.credit_number | html %]</td> > <td>[% PROCESS account_type_description account=account %]</td> > <td> >@@ -142,7 +144,7 @@ > [% END %] > <tfoot> > <tr> >- <td colspan="13">Total due</td> >+ <td colspan="14">Total due</td> > [% IF ( totalcredit ) %] > <td class="credit" style="text-align: right;">[% total | $Price %]</td> > <td> >diff --git a/members/boraccount.pl b/members/boraccount.pl >index c2befdabd0..2e73eb20da 100755 >--- a/members/boraccount.pl >+++ b/members/boraccount.pl >@@ -205,6 +205,7 @@ my $csrf_token = Koha::Token->new->generate_csrf({ > session_id => scalar $input->cookie('CGISESSID'), > }); > >+warn 'LUCASTEST' . Data::Dumper::Dumper( $logged_in_user ); > $template->param( > patron => $patron, > finesview => 1, >@@ -215,6 +216,7 @@ $template->param( > change_given => $change_given, > renew_results => $renew_results_display, > csrf_token => $csrf_token, >+ loggedinuser => $logged_in_user->unblessed, > ); > > output_html_with_http_headers $input, $cookie, $template->output; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28452
:
121390
|
121391
|
121568
|
121569