Attachment 121426 Details for Bug 28461 – Bug 28461: Specify only one tag per route

[patch] Bug 28461: Specify only one tag per route

Bug-28461-Specify-only-one-tag-per-route.patch (text/plain), 6.11 KB, created by Jonathan Druart on 2021-05-26 12:30:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-05-26 12:30:54 UTC

Size: 6.11 KB

patch

obsolete

>From 9204d10bd4ee12eda5c6dbde1247fa491e9ed7d8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 26 May 2021 14:30:00 +0200
>Subject: [PATCH] Bug 28461: Specify only one tag per route
>
>Or the route will be misplaced when generated by redoc
>
>git grep tags api|grep '",'
>---
> api/v1/swagger/paths/acquisitions_funds.json   |  2 +-
> api/v1/swagger/paths/acquisitions_vendors.json | 10 +++++-----
> api/v1/swagger/paths/cash_registers.json       |  4 ++--
> api/v1/swagger/paths/checkouts.json            |  8 ++++----
> api/v1/swagger/paths/clubs.json                |  2 +-
> api/v1/swagger/paths/holds.json                |  4 ++--
> 6 files changed, 15 insertions(+), 15 deletions(-)
>
>diff --git a/api/v1/swagger/paths/acquisitions_funds.json b/api/v1/swagger/paths/acquisitions_funds.json
>index 1b0ebce147d..31a599ac329 100644
>--- a/api/v1/swagger/paths/acquisitions_funds.json
>+++ b/api/v1/swagger/paths/acquisitions_funds.json
>@@ -3,7 +3,7 @@
>     "get": {
>       "x-mojo-to": "Acquisitions::Funds#list",
>       "operationId": "listFunds",
>-      "tags": ["acquisitions","funds"],
>+      "tags": ["funds"],
>       "produces": [
>         "application/json"
>       ],
>diff --git a/api/v1/swagger/paths/acquisitions_vendors.json b/api/v1/swagger/paths/acquisitions_vendors.json
>index 2e1eb88107c..fd76909cf41 100644
>--- a/api/v1/swagger/paths/acquisitions_vendors.json
>+++ b/api/v1/swagger/paths/acquisitions_vendors.json
>@@ -3,7 +3,7 @@
>     "get": {
>       "x-mojo-to": "Acquisitions::Vendors#list",
>       "operationId": "listVendors",
>-      "tags": ["acquisitions","vendors"],
>+      "tags": ["vendors"],
>       "produces": [
>         "application/json"
>       ],
>@@ -78,7 +78,7 @@
>     "post": {
>       "x-mojo-to": "Acquisitions::Vendors#add",
>       "operationId": "addVendor",
>-      "tags": ["acquisitions","vendors"],
>+      "tags": ["vendors"],
>       "parameters": [{
>         "name": "body",
>         "in": "body",
>@@ -140,7 +140,7 @@
>     "get": {
>       "x-mojo-to": "Acquisitions::Vendors#get",
>       "operationId": "getVendor",
>-      "tags": ["acquisitions","vendors"],
>+      "tags": ["vendors"],
>       "parameters": [{
>         "$ref": "../parameters.json#/vendoridPathParam"
>       }],
>@@ -194,7 +194,7 @@
>     "put": {
>       "x-mojo-to": "Acquisitions::Vendors#update",
>       "operationId": "updateVendor",
>-      "tags": ["acquisitions","vendors"],
>+      "tags": ["vendors"],
>       "parameters": [{
>         "$ref": "../parameters.json#/vendoridPathParam"
>       }, {
>@@ -256,7 +256,7 @@
>     "delete": {
>       "x-mojo-to": "Acquisitions::Vendors#delete",
>       "operationId": "deleteVendor",
>-      "tags": ["acquisitions","vendors"],
>+      "tags": ["vendors"],
>       "parameters": [{
>         "$ref": "../parameters.json#/vendoridPathParam"
>       }],
>diff --git a/api/v1/swagger/paths/cash_registers.json b/api/v1/swagger/paths/cash_registers.json
>index 5466cd18bea..e062f2646c6 100644
>--- a/api/v1/swagger/paths/cash_registers.json
>+++ b/api/v1/swagger/paths/cash_registers.json
>@@ -3,7 +3,7 @@
>         "get": {
>             "x-mojo-to": "CashRegisters::Cashups#list",
>             "operationId": "listCashups",
>-            "tags": ["cash_registers", "cashups"],
>+            "tags": ["cashups"],
>             "produces": ["application/json"],
>             "parameters": [{
>                     "$ref": "../parameters.json#/cash_register_id_pp"
>@@ -67,7 +67,7 @@
>         "get": {
>             "x-mojo-to": "CashRegisters::Cashups#get",
>             "operationId": "getCashup",
>-            "tags": ["cash_registers", "cashups"],
>+            "tags": ["cashups"],
>             "parameters": [{
>                 "$ref": "../parameters.json#/cashup_id_pp"
>             }],
>diff --git a/api/v1/swagger/paths/checkouts.json b/api/v1/swagger/paths/checkouts.json
>index cc2841b28dd..85fe84715e3 100644
>--- a/api/v1/swagger/paths/checkouts.json
>+++ b/api/v1/swagger/paths/checkouts.json
>@@ -3,7 +3,7 @@
>     "get": {
>       "x-mojo-to": "Checkouts#list",
>       "operationId": "listCheckouts",
>-      "tags": ["patrons", "checkouts"],
>+      "tags": ["checkouts"],
>       "parameters": [{
>         "$ref": "../parameters.json#/patron_id_qp"
>       }, {
>@@ -53,7 +53,7 @@
>     "get": {
>       "x-mojo-to": "Checkouts#get",
>       "operationId": "getCheckout",
>-      "tags": ["patrons", "checkouts"],
>+      "tags": ["checkouts"],
>       "parameters": [{
>         "$ref": "../parameters.json#/checkout_id_pp"
>       }],
>@@ -86,7 +86,7 @@
>     "post": {
>       "x-mojo-to": "Checkouts#renew",
>       "operationId": "renewCheckout",
>-      "tags": ["patrons", "checkouts"],
>+      "tags": ["checkouts"],
>       "parameters": [
>         { "$ref": "../parameters.json#/checkout_id_pp" },
>         { "$ref": "../parameters.json#/seen_pp" }
>@@ -117,7 +117,7 @@
>     "get": {
>       "x-mojo-to": "Checkouts#allows_renewal",
>       "operationId": "allows_renewalCheckout",
>-      "tags": ["patrons", "checkouts"],
>+      "tags": ["checkouts"],
>       "parameters": [{
>         "$ref": "../parameters.json#/checkout_id_pp"
>       }],
>diff --git a/api/v1/swagger/paths/clubs.json b/api/v1/swagger/paths/clubs.json
>index 32862074d39..6a4ae46e273 100644
>--- a/api/v1/swagger/paths/clubs.json
>+++ b/api/v1/swagger/paths/clubs.json
>@@ -3,7 +3,7 @@
>         "post": {
>             "x-mojo-to": "Clubs::Holds#add",
>             "operationId": "addClubHold",
>-            "tags": ["holds", "clubs"],
>+            "tags": ["clubs"],
>             "parameters": [{
>                 "$ref": "../parameters.json#/club_id_pp"
>               }, {
>diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json
>index 66dd21c7333..b875f30fba4 100644
>--- a/api/v1/swagger/paths/holds.json
>+++ b/api/v1/swagger/paths/holds.json
>@@ -3,7 +3,7 @@
>     "get": {
>       "x-mojo-to": "Holds#list",
>       "operationId": "listHolds",
>-      "tags": ["patrons", "holds"],
>+      "tags": ["holds"],
>       "parameters": [
>         {
>           "name": "hold_id",
>@@ -179,7 +179,7 @@
>     "post": {
>       "x-mojo-to": "Holds#add",
>       "operationId": "addHold",
>-      "tags": ["patrons", "holds"],
>+      "tags": ["holds"],
>       "parameters": [
>         {
>           "name": "body",
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28461: 121426 | 121427 | 121428 | 121430 | 121431