Bugzilla – Attachment 121532 Details for
Bug 28496
Club holds form broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28496: Club holds pickup locations don't come from the API
Bug-28496-Club-holds-pickup-locations-dont-come-fr.patch (text/plain), 1.61 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-06-01 16:18:59 UTC
(
hide
)
Description:
Bug 28496: Club holds pickup locations don't come from the API
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-06-01 16:18:59 UTC
Size:
1.61 KB
patch
obsolete
>From b90a05a1b19160847b7092fbb03e5bcf7d1ef1e2 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 1 Jun 2021 13:14:05 -0300 >Subject: [PATCH] Bug 28496: Club holds pickup locations don't come from the > API > >This patch fixes a issue that is generated by the fact different inputs >were reusing the same id. > >To test: >1. Have a club with some enrollments >2. Make sure you have your circ rules to allow any library be a pickup > location. >3. Search for a biblio >4. Try placing a club hold >=> FAIL: The dropdown only has the (currently) logged in library. >5. Apply this patch >6. Repeat 3-4 >=> SUCCESS: The dropdown has all the options >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 023049f011..00ceeee8c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -191,7 +191,7 @@ > </li> > <li> > <label for="pickup">Pickup at:</label> >- <select name="pickup" id="pickup"> >+ <select name="pickup" id="pickup_club"> > [% PROCESS options_for_libraries libraries => Branches.all({ selected => club.branchcode, search_params => { pickup_location => 1 } }) %] > </select> > </li> >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28496
:
121532
|
121553
|
121566