Bugzilla – Attachment 121538 Details for
Bug 28490
Cannot modify patrons in some categories (e.g. Child category)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28490: Remove "relationship" from the patron form
Bug-28490-Remove-relationship-from-the-patron-form.patch (text/plain), 3.58 KB, created by
Jonathan Druart
on 2021-06-02 14:01:15 UTC
(
hide
)
Description:
Bug 28490: Remove "relationship" from the patron form
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-06-02 14:01:15 UTC
Size:
3.58 KB
patch
obsolete
>From 15268448a64be784c1201d6b13e5a7aa00367f28 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 2 Jun 2021 15:58:15 +0200 >Subject: [PATCH] Bug 28490: Remove "relationship" from the patron form > >This is managed by the "guarantor" section (table borrower_relationships >in DB). It shouldn't be a separate section in the form. >We removed the DB column on bug 28490. > >It caused an exception when the patron's data was stored. > > Patron modification failed! - No property relationship for Koha::Patron at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl > >Test plan: >Edit a patron with category "Child" and save >--- > .../prog/en/modules/members/memberentrygen.tt | 17 ----------------- > members/memberentry.pl | 1 + > 2 files changed, 1 insertion(+), 17 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index f874e80de94..699ddb4b559 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -629,23 +629,6 @@ legend:hover { > </li> > [% END # /UNLESS noaltcontactfirstname %] > >- [% UNLESS norelationship %] >- [% IF possible_relationships %] >- <li> >- <label for="relationship">Relationship: </label> >- <select class="relationship" name="relationship"> >- <option value=""></option> >- [% FOREACH pr IN possible_relationships.split('\|') %] >- [% IF pr == relationship %] >- <option value="[% pr | html %]" selected="selected">[% pr | html %]</option> >- [% ELSE %] >- <option value="[% pr | html %]">[% pr | html %]</option> >- [% END %] >- [% END %] >- </select> >- </li> >- [% END #/IF possible_relationships %] >- [% END # /UNLESS norelationship %] > </ol> > </fieldset> <!-- /#non_patron_guarantor --> > [% END # /UNLESS nocontactname && nocontactfirstname && norelationship %] >diff --git a/members/memberentry.pl b/members/memberentry.pl >index da8a324c784..59be3d29133 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -250,6 +250,7 @@ if ( $op eq 'insert' || $op eq 'modify' || $op eq 'save' || $op eq 'duplicate' ) > qr/^guarantor_firstname$/, > qr/^guarantor_surname$/, > qr/^delete_guarantor$/, >+ qr/^relationship$/, > ); > for my $regexp (@keys_to_delete) { > for (keys %newdata) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28490
:
121538
|
121545
|
121546
|
121547
|
121548
|
121549
|
121550
|
121551
|
121552
|
121595
|
121596
|
121597
|
121598
|
121599
|
121600
|
121601
|
121602
|
121655
|
121656
|
121661
|
121662
|
121663
|
121664
|
121665
|
121666
|
121667
|
121669
|
121811
|
121812
|
121813
|
121814
|
121815
|
121816
|
121817
|
121818
|
121823
|
121824
|
121825
|
121826
|
121827
|
121828
|
121829
|
121830
|
121915