Bugzilla – Attachment 121550 Details for
Bug 28490
Cannot modify patrons in some categories (e.g. Child category)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28490: Comment out the relationship data removing DB update step
Bug-28490-Comment-out-the-relationship-data-removi.patch (text/plain), 2.18 KB, created by
Joonas Kylmälä
on 2021-06-02 18:01:03 UTC
(
hide
)
Description:
Bug 28490: Comment out the relationship data removing DB update step
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-06-02 18:01:03 UTC
Size:
2.18 KB
patch
obsolete
>From a44ff55ff6eacaf379615d92584d0b458f7a3f9a Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Wed, 2 Jun 2021 20:22:51 +0300 >Subject: [PATCH] Bug 28490: Comment out the relationship data removing DB > update step > >These columns that were actively used to store non-patron guarantor >relationship info were dropped incorrectly. In a later patch the >relationship fields will be re-added. >--- > installer/data/mysql/updatedatabase.pl | 36 ++++++++++++++------------ > 1 file changed, 20 insertions(+), 16 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index aadeefd9ed..30a52ed352 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -24229,23 +24229,27 @@ if( CheckVersion( $DBversion ) ) { > > $DBversion = '20.12.00.048'; > if( CheckVersion( $DBversion ) ) { >- if ( column_exists( 'borrowers', 'relationship' ) ) { >- $dbh->do(q{ >- ALTER TABLE borrowers DROP COLUMN relationship >- }); >- } >- >- if ( column_exists( 'deletedborrowers', 'relationship' ) ) { >- $dbh->do(q{ >- ALTER TABLE deletedborrowers DROP COLUMN relationship >- }); >- } > >- if ( column_exists( 'borrower_modifications', 'relationship' ) ) { >- $dbh->do(q{ >- ALTER TABLE borrower_modifications DROP COLUMN relationship >- }); >- } >+ # This DB upgrade has been commented out because it removes >+ # actively used data, the relationship columns will be added back >+ >+ # if ( column_exists( 'borrowers', 'relationship' ) ) { >+ # $dbh->do(q{ >+ # ALTER TABLE borrowers DROP COLUMN relationship >+ # }); >+ # } >+ >+ # if ( column_exists( 'deletedborrowers', 'relationship' ) ) { >+ # $dbh->do(q{ >+ # ALTER TABLE deletedborrowers DROP COLUMN relationship >+ # }); >+ # } >+ >+ # if ( column_exists( 'borrower_modifications', 'relationship' ) ) { >+ # $dbh->do(q{ >+ # ALTER TABLE borrower_modifications DROP COLUMN relationship >+ # }); >+ # } > > NewVersion( $DBversion, 26995, "Drop column relationship from borrower tables"); > } >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28490
:
121538
|
121545
|
121546
|
121547
|
121548
|
121549
|
121550
|
121551
|
121552
|
121595
|
121596
|
121597
|
121598
|
121599
|
121600
|
121601
|
121602
|
121655
|
121656
|
121661
|
121662
|
121663
|
121664
|
121665
|
121666
|
121667
|
121669
|
121811
|
121812
|
121813
|
121814
|
121815
|
121816
|
121817
|
121818
|
121823
|
121824
|
121825
|
121826
|
121827
|
121828
|
121829
|
121830
|
121915