Bugzilla – Attachment 121579 Details for
Bug 28510
Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28510: Remove marking of closed branches as 'disable_transfer'
Bug-28510-Remove-marking-of-closed-branches-as-dis.patch (text/plain), 2.02 KB, created by
Kyle M Hall (khall)
on 2021-06-03 10:59:01 UTC
(
hide
)
Description:
Bug 28510: Remove marking of closed branches as 'disable_transfer'
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-06-03 10:59:01 UTC
Size:
2.02 KB
patch
obsolete
>From e6643718205f719972f9f682aac0e368031f35bd Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 3 Jun 2021 06:57:52 -0400 >Subject: [PATCH] Bug 28510: Remove marking of closed branches as > 'disable_transfer' > >We no longer need to act as if closed branches were marked as >disable_transfer. This allows us to clean up a nice bit of code. >--- > C4/HoldsQueue.pm | 9 +-------- > admin/transport-cost-matrix.pl | 2 +- > 2 files changed, 2 insertions(+), 9 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index e1ae3c4830..15ff772079 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -63,7 +63,6 @@ Returns Transport Cost Matrix as a hashref <to branch code> => <from branch code > > sub TransportCostMatrix { > my ( $params ) = @_; >- my $ignore_holds_queue_skip_closed = $params->{ignore_holds_queue_skip_closed}; > > my $dbh = C4::Context->dbh; > my $transport_costs = $dbh->selectall_arrayref("SELECT * FROM transport_cost",{ Slice => {} }); >@@ -80,14 +79,8 @@ sub TransportCostMatrix { > cost => $cost, > disable_transfer => $disabled > }; >- >- if ( !$ignore_holds_queue_skip_closed && C4::Context->preference("HoldsQueueSkipClosed") ) { >- $calendars->{$from} ||= Koha::Calendar->new( branchcode => $from ); >- $transport_cost_matrix{$to}{$from}{disable_transfer} ||= >- $calendars->{$from}->is_holiday( $today ); >- } >- > } >+ > return \%transport_cost_matrix; > } > >diff --git a/admin/transport-cost-matrix.pl b/admin/transport-cost-matrix.pl >index e28ee89b79..34f6ca7869 100755 >--- a/admin/transport-cost-matrix.pl >+++ b/admin/transport-cost-matrix.pl >@@ -45,7 +45,7 @@ my $update = ( $input->param('op') // '' ) eq 'set-cost-matrix'; > > my ($cost_matrix, $have_matrix); > unless ($update) { >- $cost_matrix = TransportCostMatrix({ ignore_holds_queue_skip_closed => 1 }); >+ $cost_matrix = TransportCostMatrix(); > $have_matrix = keys %$cost_matrix if $cost_matrix; > } > >-- >2.30.1 (Apple Git-130)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28510
:
121578
|
121579
|
121588
|
122193
|
122194
|
122195
|
124842
|
125280
|
125281
|
125282
|
125283