Bugzilla – Attachment 121588 Details for
Bug 28510
Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28510: Remove unnecessary conditional
Bug-28510-Remove-unnecessary-conditional.patch (text/plain), 1.31 KB, created by
Kyle M Hall (khall)
on 2021-06-03 11:34:06 UTC
(
hide
)
Description:
Bug 28510: Remove unnecessary conditional
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-06-03 11:34:06 UTC
Size:
1.31 KB
patch
obsolete
>From f2de5b138cae5034653354b980b90321562af9e4 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 3 Jun 2021 07:29:52 -0400 >Subject: [PATCH] Bug 28510: Remove unnecessary conditional > >It makes sense to use items by branch to get the list of branches, as it >already tells use which branches have available items. We could use >branches to pull from instead, but all we would accomplish is added >extra ununsed loop iterations. We already know that any additional >branches in the branches to pull loop have no items to fill holds. >If they did, they would be in the items_by_branch hash. >--- > C4/HoldsQueue.pm | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 15ff772079..7141ffa986 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -600,12 +600,7 @@ sub MapItemsToHoldRequests { > } > > unless ($itemnumber) { >- # not found yet, fall back to basics >- if ($branches_to_use) { >- $pull_branches = $branches_to_use; >- } else { >- $pull_branches = [keys %items_by_branch]; >- } >+ $pull_branches = [keys %items_by_branch]; > > # Try picking items where the home and pickup branch match first > PULL_BRANCHES: >-- >2.30.1 (Apple Git-130)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28510
:
121578
|
121579
|
121588
|
122193
|
122194
|
122195
|
124842
|
125280
|
125281
|
125282
|
125283