Attachment 121613 Details for Bug 28336 – Bug 28336: Add missing input for item_action

[patch] Bug 28336: Add missing input for item_action

Bug-28336-Add-missing-input-for-itemaction.patch (text/plain), 1.88 KB, created by Katrin Fischer on 2021-06-03 22:53:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-06-03 22:53:33 UTC

Size: 1.88 KB

patch

obsolete

>From b4f5439c9a04b28c0f245d72cb156f746b9aad7f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 12 May 2021 17:00:57 +0000
>Subject: [PATCH] Bug 28336: Add missing input for item_action
>
>To test:
>1 - Stage a marc file of authorities
>2 - Manage the staged file
>3 - Attempt to change the matching rule
>4 - 500 Error, in intranet-error.log:
>[Wed May 12 16:53:03.046652 2021] [cgi:error] [pid 52072] [client 172.19.0.1:50580] AH01215: C4::ImportBatch::SetImportBatchItemAction(): DBI Exception: DBD::mysql::st execute failed: Column 'item_action' cannot be null [for Statement "UPDATE import_batches SET item_action = ? WHERE import_batch_id = ?" with ParamValues: 0=undef, 1="1"] at /kohadevbox/koha/tools/manage-marc-import.pl line 160: /kohadevbox/koha/tools/manage-marc-import.pl, referer: http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1
>5 - Apply patch
>6 - Reload page and change matching rule
>7 - Success!
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
>index 2a56b1a2d3..601d0a3dbd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
>@@ -223,6 +223,8 @@
>                                             [% END %]
>                                         [% END %]
>                                     </li>
>+                                [% ELSE %]
>+                                    <input type ="hidden" name="item_action" value="ignore">
>                                 [% END %]
>                             </ol>
>                             [% IF ( can_commit ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28336: 120893 | 121613 | 123134