Bugzilla – Attachment 121685 Details for
Bug 27064
Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27064: (QA follow-up) Add error message only if we have one defined
Bug-27064-QA-follow-up-Add-error-message-only-if-w.patch (text/plain), 1.61 KB, created by
Martin Renvoize (ashimema)
on 2021-06-07 14:48:10 UTC
(
hide
)
Description:
Bug 27064: (QA follow-up) Add error message only if we have one defined
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-06-07 14:48:10 UTC
Size:
1.61 KB
patch
obsolete
>From fd4eb0c0e654c6711f458c29f569c3a676ceaffc Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Mon, 7 Jun 2021 17:07:04 +0300 >Subject: [PATCH] Bug 27064: (QA follow-up) Add error message only if we have > one defined >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This moves the DestinationEqualsHolding error message addition to if >clause so the value is added to %err hash only when there is actually >an error. Then we only append to the @errmsgloop array the error >message if one was defined. > >To test: > 1) Create a hold request to a pickup library where the item currently > is not > 2) Add transfer to the pickup library using branchtransfers.pl and > notice without this patch we get and empty message box but with this > patch we don't get it. > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > circ/branchtransfers.pl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl >index bb508f77a0..ca14276e09 100755 >--- a/circ/branchtransfers.pl >+++ b/circ/branchtransfers.pl >@@ -213,8 +213,10 @@ foreach my $code ( keys %$messages ) { > $err{patron} = $patron; > } > } >- $err{errdesteqholding} = ( $code eq 'DestinationEqualsHolding' ); >- push( @errmsgloop, \%err ); >+ elsif ( $code eq 'DestinationEqualsHolding' ) { >+ $err{errdesteqholding} = 1; >+ } >+ push( @errmsgloop, \%err ) if (keys %err); > } > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27064
:
113877
|
114712
|
120222
|
120759
|
120764
|
121065
|
121066
|
121067
|
121090
|
121091
|
121092
|
121093
|
121141
|
121142
|
121143
|
121144
|
121670
|
121671
|
121672
|
121673
|
121674
|
121675
|
121676
|
121677
|
121678
|
121679
|
121680
|
121681
|
121682
|
121683
|
121684
| 121685 |
121981