Bugzilla – Attachment 121690 Details for
Bug 28520
Cancelling a hold that is in transit hides item's transit status
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28520: Allow creating a new transit request for item with cancelled transfer
Bug-28520-Allow-creating-a-new-transit-request-for.patch (text/plain), 1.12 KB, created by
Joonas Kylmälä
on 2021-06-07 17:13:13 UTC
(
hide
)
Description:
Bug 28520: Allow creating a new transit request for item with cancelled transfer
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-06-07 17:13:13 UTC
Size:
1.12 KB
patch
obsolete
>From 072a347d8bc31c917ccc95237e162d6cd50f8bc7 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Mon, 7 Jun 2021 20:05:25 +0300 >Subject: [PATCH] Bug 28520: Allow creating a new transit request for item with > cancelled transfer > >Setting $validTransfer=1 will allow us to trigger automatically a new >transfer at check-in time. With this patch applied it is possible to >return back home an item with cancelled hold that is in-transit. This >is a fix to the regression caused by bug 26078. >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index aaf32ef967..6a4dbfd3d5 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2166,7 +2166,7 @@ sub AddReturn { > > # if we have a transfer to complete, we update the line of transfers with the datearrived > if ($transfer) { >- $validTransfer = 0; >+ $validTransfer = 0 unless defined $transfer->datecancelled; > if ( $transfer->in_transit ) { > if ( $transfer->tobranch eq $branch ) { > $transfer->receive; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28520
:
121686
|
121689
|
121690
|
121691
|
121693
|
121708
|
121709
|
121710
|
121711
|
121712
|
121718
|
121719
|
121720
|
121721
|
121722
|
121843
|
121844
|
121845
|
121846
|
121847
|
121951
|
121952
|
121953
|
121954
|
121955
|
121985
|
122005
|
122006
|
122007