Attachment 121708 Details for Bug 28520 – Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling"

[patch] Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling"

Bug-28520-Revert-Bug-12362-QA-follow-up-Fix-ModIte.patch (text/plain), 1.47 KB, created by Joonas Kylmälä on 2021-06-08 08:40:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-06-08 08:40:53 UTC

Size: 1.47 KB

patch

obsolete

>From 92510dabb58010166dc80907105234d9f6636bee Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Tue, 8 Jun 2021 07:47:32 +0000
>Subject: [PATCH] Bug 28520: Revert "Bug 12362: (QA follow-up) Fix
> ModItemTransfer cancellation handling"
>
>This reverts commit fbba09f63f200d3e57a8612554984d807867cf84.
>
>This commit was part of a series adding adding reverse transfers, i.e.
>transfers that were created for transfers that were cancelled and
>we wanted the item to return back to its sending library. This however
>hid the information about transfer happening and we need another approach
>to the problem.
>---
> Koha/Item.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Item.pm b/Koha/Item.pm
>index 2bad020287..47a86eb0bb 100644
>--- a/Koha/Item.pm
>+++ b/Koha/Item.pm
>@@ -456,6 +456,9 @@ sub request_transfer {
>     Koha::Exceptions::Item::Transfer::InQueue->throw( transfer => $request )
>       if ( $request && !$params->{enqueue} && !$params->{replace} );
> 
>+    $request->cancel( { reason => $params->{reason}, force => 1 } )
>+      if ( defined($request) && $params->{replace} );
>+
>     my $transfer = Koha::Item::Transfer->new(
>         {
>             itemnumber    => $self->itemnumber,
>@@ -467,9 +470,6 @@ sub request_transfer {
>         }
>     )->store();
> 
>-    $request->cancel( { reason => $params->{reason}, force => 1 } )
>-      if ( defined($request) && $params->{replace} );
>-
>     return $transfer;
> }
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28520: 121686 | 121689 | 121690 | 121691 | 121693 | 121708 | 121709 | 121710 | 121711 | 121712 | 121718 | 121719 | 121720 | 121721 | 121722 | 121843 | 121844 | 121845 | 121846 | 121847 | 121951 | 121952 | 121953 | 121954 | 121955 | 121985 | 122005 | 122006 | 122007