Attachment 121709 Details for Bug 28520 – Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation"

[patch] Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation"

Bug-28520-Revert-Bug-12362-Cancel-transfer-with-ho.patch (text/plain), 3.83 KB, created by Joonas Kylmälä on 2021-06-08 08:40:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-06-08 08:40:58 UTC

Size: 3.83 KB

patch

obsolete

>From 3b12a283b60c8eb26bb61b624aa35d470c5c9882 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Tue, 8 Jun 2021 07:50:05 +0000
>Subject: [PATCH] Bug 28520: Revert "Bug 12362: Cancel transfer with hold
> cancelation"
>
>This reverts commit 6c105829144cd341a4bc65ad8d0ee1f996b423d4.
>
>This commit was part of a series adding adding reverse transfers, i.e.
>transfers that were created for transfers that were cancelled and
>we wanted the item to return back to its sending library. This however
>hid the information about transfer happening and we need another approach
>to the problem.
>---
> Koha/Hold.pm                                  |  9 -------
> Koha/Item/Transfer.pm                         | 24 ++++---------------
> .../prog/en/modules/circ/returns.tt           |  2 --
> 3 files changed, 4 insertions(+), 31 deletions(-)
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index 2bdae269ec..bd5458f494 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -511,17 +511,8 @@ Cancel a hold:
> 
> sub cancel {
>     my ( $self, $params ) = @_;
>-
>     $self->_result->result_source->schema->txn_do(
>         sub {
>-            if ( $self->is_in_transit ) {
>-                my $transfer = $self->item->get_transfer;
>-                # NOTE: Transfers are well bound with Holds.. as such we have to check that there is actually a
>-                # transfer enqueued and in transit here prior to trying to cancel it.
>-                if ( $transfer && $transfer->in_transit ) {
>-                    $transfer->cancel({ reason => 'CancelReserve', force => 1 });
>-                }
>-            }
>             $self->cancellationdate( dt_from_string->strftime( '%Y-%m-%d %H:%M:%S' ) );
>             $self->priority(0);
>             $self->cancellation_reason( $params->{cancellation_reason} );
>diff --git a/Koha/Item/Transfer.pm b/Koha/Item/Transfer.pm
>index 4112b3fab9..aded4e23a5 100644
>--- a/Koha/Item/Transfer.pm
>+++ b/Koha/Item/Transfer.pm
>@@ -52,20 +52,6 @@ sub item {
>     return Koha::Item->_new_from_dbic($item_rs);
> }
> 
>-=head3 from_library
>-
>-  my $from_library = $transfer->from_library;
>-
>-Returns the associated from_library for this transfer.
>-
>-=cut
>-
>-sub from_library {
>-    my ($self) = @_;
>-    my $from_library_rs = $self->_result->frombranch;
>-    return Koha::Library->_new_from_dbic($from_library_rs);
>-}
>-
> =head3 transit
> 
> Set the transfer as in transit by updating the datesent time.
>@@ -161,12 +147,10 @@ sub cancel {
>     # Set up return transfer if transfer was force cancelled whilst in transit
>     # NOTE: We don't catch here, as we're happy to fail if there are already
>     # other transfers in the queue.
>-    if ($in_transit) {
>-        try {
>-            $self->item->request_transfer(
>-                { to => $self->from_library, reason => 'TransferCancellation' } );
>-        };
>-    }
>+    try {
>+        $self->item->request_transfer(
>+            { to => $self->frombranch, reason => 'TransferCancellation' } );
>+    };
> 
>     return $self;
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 0fdb3fd6c6..8f06ab6d72 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -134,8 +134,6 @@
>                                              [%- CASE 'Reserve' -%]Reserve
>                                              [%- CASE 'LostReserve' -%]Lost reserve
>                                              [%- CASE 'CancelReserve' -%]Cancelled reserve
>-                                             [%- CASE 'TransferCancellation' -%]Transfer was cancelled whilst in transit
>-                                             [%- CASE -%][% trigger | html %]
>                                          [%- END -%]
>                                      </p>
>                                  </div>
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28520: 121686 | 121689 | 121690 | 121691 | 121693 | 121708 | 121709 | 121710 | 121711 | 121712 | 121718 | 121719 | 121720 | 121721 | 121722 | 121843 | 121844 | 121845 | 121846 | 121847 | 121951 | 121952 | 121953 | 121954 | 121955 | 121985 | 122005 | 122006 | 122007