Attachment 121794 Details for Bug 28545 – Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313

[patch] Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313

Bug-28545-Noisy-uninitialized-warn-at-opac-MARCdet.patch (text/plain), 1.22 KB, created by Marcel de Rooy on 2021-06-10 14:04:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-06-10 14:04:13 UTC

Size: 1.22 KB

patch

obsolete

>From b414c59897d8ccd42e5aece131a5d556fde50bd1 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 10 Jun 2021 14:02:16 +0000
>Subject: [PATCH] Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl
> line 313
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>You need an item with some null values.
>Check your logs before and after applying this change.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> opac/opac-MARCdetail.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl
>index 4362270959..90db18fdf9 100755
>--- a/opac/opac-MARCdetail.pl
>+++ b/opac/opac-MARCdetail.pl
>@@ -310,8 +310,8 @@ foreach my $field (@fields) {
>             $item->{ $subf[$i][0] } .= $subf[$i][1];
>         }
>         else {
>-            $item->{ $subf[$i][0] } .= GetAuthorisedValueDesc( $field->tag(), $subf[$i][0],
>-                $subf[$i][1], '', $tagslib, '', 'opac' );
>+            $item->{ $subf[$i][0] } .= ( GetAuthorisedValueDesc( $field->tag(), $subf[$i][0],
>+                $subf[$i][1], '', $tagslib, '', 'opac' ) // q{} );
>         }
> 
>         my $kohafield = $tagslib->{ $field->tag() }->{ $subf[$i][0] }->{kohafield};
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28545: 121794 | 121810 | 121894 | 122164