Bugzilla – Attachment 121801 Details for
Bug 24434
C4::Circulation::updateWrongTransfer is never called but should be
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24434: Submit on print slip
Bug-24434-Submit-on-print-slip.patch (text/plain), 4.21 KB, created by
Kyle M Hall (khall)
on 2021-06-10 16:20:25 UTC
(
hide
)
Description:
Bug 24434: Submit on print slip
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-06-10 16:20:25 UTC
Size:
4.21 KB
patch
obsolete
>From 44641507162b98ccc6f7fbebcabfdb6c6afd51c8 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 17 May 2021 10:42:04 +0100 >Subject: [PATCH] Bug 24434: Submit on print slip > >This patch ensures that the print slip option on the WrongTransfer modal >also submits the form and thus triggers the actual transfer of the item. > >We also prevent a double transfer submission (and thus a cancellation >line appearing in the branchtransfers table) for the case where a >transfer back home is triggered. > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 668e67db58..2108bda509 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -459,7 +459,7 @@ > <!-- CONFIRM --> > <button class="btn btn-default approve" type="submit"><i class="fa fa-check"></i> OK</button> > <!-- PRINT SLIP --> >- <button type="button" data-dismiss="modal" class="btn btn-default transit openWin" data-transfer="[% NewTransfer | html %]" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% TransferWaitingAt | uri %]&op=slip"><i class="fa fa-print"></i> Print transfer slip</button> >+ <button type="button" data-dismiss="modal" class="btn btn-default submit openWin" data-transfer="[% NewTransfer | html %]" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% TransferWaitingAt | uri %]&op=slip"><i class="fa fa-print"></i> Print transfer slip</button> > <!-- CANCEL TRANSFER --> > <button type="button" data-dismiss="modal" class="btn btn-default deny cancel"><i class="fa fa-times"></i> Cancel transfer</button> > </div> <!-- /.modal-footer --> >@@ -606,7 +606,7 @@ > <button type="button" data-dismiss="modal" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button> > [% ELSE %] > <button type="button" data-dismiss="modal" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button> >- <button type="button" data-dismiss="modal" name="dotransfer" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&branchcode=[% transfer | uri %]&op=slip"><i class="fa fa-print"></i> Print slip</button> >+ <button type="button" data-dismiss="modal" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&branchcode=[% transfer | uri %]&op=slip"><i class="fa fa-print"></i> Print slip</button> > [% END %] > <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" /> > <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" /> >@@ -1128,6 +1128,10 @@ > Dopop( $(this).data("url") ); > }); > >+ $('.submit').on("click",function(e){ >+ this.form.submit(); >+ }); >+ > $('.cancel').on("click",function(e){ > var docancel = $("<input>").attr("type", "hidden").attr("name", "canceltransfer").val(1); > $('#wrongtransferform').append(docancel); >-- >2.30.1 (Apple Git-130)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24434
:
97449
|
97550
|
99829
|
120625
|
120631
|
120632
|
120657
|
120658
|
120683
|
120684
|
120757
|
120758
|
121029
|
121030
|
121031
|
121032
|
121033
|
121034
|
121057
|
121058
|
121059
|
121060
|
121061
|
121071
|
121072
|
121073
|
121074
|
121075
|
121515
|
121702
|
121703
|
121704
|
121705
|
121706
|
121707
|
121798
|
121799
|
121800
| 121801 |
121802
|
121803
|
121804