Bugzilla – Attachment 121813 Details for
Bug 28490
Cannot modify patrons in some categories (e.g. Child category)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the about page"
0003-Bug-28490-Revert-Bug-26995-Fix-SQL-syntax-error-on-t.patch (text/plain), 1.68 KB, created by
Emmi Takkinen
on 2021-06-11 10:26:35 UTC
(
hide
)
Description:
Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the about page"
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2021-06-11 10:26:35 UTC
Size:
1.68 KB
patch
obsolete
>From bfb5c2888493ec26baa2aad5d8ef68c9e364c98e Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Wed, 2 Jun 2021 17:12:16 +0000 >Subject: [PATCH 3/8] Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the > about page" > >This reverts commit 1131bb687f14fef7b4cb5f3b194711e85f9227af. > >It was part of a patch set that removed actively used data and must be >therefore reverted. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> >Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >--- > about.pl | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/about.pl b/about.pl >index 9b59a6aa65..de53ac02f5 100755 >--- a/about.pl >+++ b/about.pl >@@ -496,13 +496,17 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs; > { > my $dbh = C4::Context->dbh; > my ($bad_relationships_count) = $dbh->selectall_arrayref(q{ >- SELECT COUNT(*) FROM borrower_relationships WHERE relationship='_bad_data' >+ SELECT COUNT(*) >+ FROM ( >+ SELECT relationship FROM borrower_relationships WHERE relationship='_bad_data' > }); > > $bad_relationships_count = $bad_relationships_count->[0]->[0]; > > my $existing_relationships = $dbh->selectall_arrayref(q{ >- SELECT DISTINCT(relationship) FROM borrower_relationships WHERE relationship IS NOT NULL >+ SELECT DISTINCT(relationship) >+ FROM ( >+ SELECT relationship FROM borrower_relationships WHERE relationship IS NOT NULL > }); > > my %valid_relationships = map { $_ => 1 } split( /,|\|/, C4::Context->preference('borrowerRelationship') ); >-- >2.25.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28490
:
121538
|
121545
|
121546
|
121547
|
121548
|
121549
|
121550
|
121551
|
121552
|
121595
|
121596
|
121597
|
121598
|
121599
|
121600
|
121601
|
121602
|
121655
|
121656
|
121661
|
121662
|
121663
|
121664
|
121665
|
121666
|
121667
|
121669
|
121811
|
121812
|
121813
|
121814
|
121815
|
121816
|
121817
|
121818
|
121823
|
121824
|
121825
|
121826
|
121827
|
121828
|
121829
|
121830
|
121915