Attachment 12185 Details for Bug 8768 – Proposed patch

[patch] Proposed patch

0001-bug-8768-correct-an-error-in-ItemType.t.patch (text/plain), 1.17 KB, created by Colin Campbell on 2012-09-13 09:53:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Campbell

Created: 2012-09-13 09:53:02 UTC

Size: 1.17 KB

patch

obsolete

>From dc4d32c75c0a2c5c913c2ba8de7390c773f53068 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Thu, 13 Sep 2012 10:37:56 +0100
>Subject: [PATCH] bug 8768 correct an error in ItemType.t
>
>The second test in ItemType.t tests that an empty table
>returns no rows however as Mock::DBD has no resultset
>it fails with an error in DBI It requires that an
>empty resultset is defined in Mock::DBD first
>This patch adds that mocked empty table
>---
> t/ItemType.t | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/t/ItemType.t b/t/ItemType.t
>index 476ca19..87e090e 100755
>--- a/t/ItemType.t
>+++ b/t/ItemType.t
>@@ -1,6 +1,5 @@
> #!/usr/bin/perl
> #
>-# This Koha test module is a stub!
> # Add more tests here!!!
> 
> use strict;
>@@ -33,7 +32,15 @@ my $itemtypes = [
>     [ 'CD', 'CDRom', 0, 0, '', '' ]
> ];
> 
>+my $itemtypes_empty = [
>+    [
>+        'itemtype', 'description', 'rentalcharge', 'notforloan',
>+        'imageurl', 'summary'
>+    ],
>+];
>+
> my $dbh = C4::Context->dbh();
>+$dbh->{mock_add_resultset} = $itemtypes_empty;
> 
> my @itemtypes = C4::ItemType->all();
> is( @itemtypes, 0, 'Testing all itemtypes is empty' );
>-- 
>1.7.12.363.g53284de
>

Actions: View | Diff | Splinter Review

Attachments on bug 8768: 12185 | 12205