Attachment 121865 Details for Bug 28488 – Bug 28488: Javascript error in self-checkout (__ is not defined)

[patch] Bug 28488: Javascript error in self-checkout (__ is not defined)

Bug-28488-Javascript-error-in-self-checkout--is-no.patch (text/plain), 1.75 KB, created by Nick Clemens (kidclamp) on 2021-06-11 16:58:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-06-11 16:58:21 UTC

Size: 1.75 KB

patch

obsolete

>From 0f73110fba7628c9e7fb299950925684b246c373 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 7 Jun 2021 16:02:35 +0000
>Subject: [PATCH] Bug 28488: Javascript error in self-checkout (__ is not
> defined)
>
>This patch adds inclusion of the internationalization JavaScript which
>is required by the newest version of the DataTables include. It
>references the double-underscore function provided by i18n.js.
>
>To test, apply the patch and log into the self-checkout system as a user
>with checkouts. The table of checkouts should display correctly and
>there should be no JavaScript errors in the console.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>index 339a0818e7..33d1d90b3e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>@@ -25,8 +25,14 @@
> [% IF ( Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') | $raw %]</style>[% END %]
> [% IF ( Koha.Preference('SCOUserCSS') ) %]<style>[% Koha.Preference('SCOUserCSS') | $raw %]</style>[% END %]
> <script>
>+    var Koha = {};
>     function _(s) { return s } // dummy function for gettext
> </script>
>+[% IF lang && lang != 'en' %]
>+    [% Asset.js(lang _ '/js/locale_data.js') | $raw %]
>+[% END %]
>+[% Asset.js('js/Gettext.js') | $raw %]
>+[% Asset.js('js/i18n.js') | $raw %]
> [% Asset.js("lib/modernizr.min.js") | $raw %]
> </head>
> <body id="sco_main" class="sco" onload="dofocus();" onunload="mungeHistory();">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28488: 121687 | 121695 | 121865