Bugzilla – Attachment 121950 Details for
Bug 28243
Accessibility: Staff interface - add captions to tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28243: reports folder
Bug-28243-reports-folder.patch (text/plain), 16.50 KB, created by
Wainui Witika-Park
on 2021-06-15 05:49:56 UTC
(
hide
)
Description:
Bug 28243: reports folder
Filename:
MIME Type:
Creator:
Wainui Witika-Park
Created:
2021-06-15 05:49:56 UTC
Size:
16.50 KB
patch
obsolete
>From 9444bf92ea404f80d89718fb511525aa51f4a08c Mon Sep 17 00:00:00 2001 >From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> >Date: Tue, 15 Jun 2021 03:14:21 +0000 >Subject: [PATCH] Bug 28243: reports folder > >Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still >present for those who use screen-readers. > >To test: >1) Apply patch and dependencies >2) Go to Staff Client >3) Go to reports >4) Go to each of the pages/files and check if they have tables >5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" > >Sponsored-by: Catalyst IT >--- > .../intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt | 1 + > .../intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt | 1 + > .../intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt | 2 ++ > .../intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt | 1 + > .../intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt | 6 ++---- > .../intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt | 2 ++ > .../prog/en/modules/reports/guided_reports_start.tt | 7 +++++++ > .../intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt | 9 ++++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt | 1 + > .../intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt | 1 + > .../intranet-tmpl/prog/en/modules/reports/reserves_stats.tt | 9 ++++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt | 1 + > 17 files changed, 38 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >index 729bfac36e..606cc4d0a3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >@@ -106,6 +106,7 @@ > <fieldset class="rows"> > <legend>Acquisitions statistics</legend> > <table> >+ <caption class="sr-only">Acquisitions statistics</caption> > <thead> > <tr> > <th>Title</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >index 502ac75124..484067ca39 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >@@ -83,6 +83,7 @@ > [% END %] > > <table> >+ <caption class="sr-only">Patrons</caption> > <tr> > <th rowspan="2">Rank</th> > [% FOREACH loopco IN mainloo.loopcol %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt >index c54a95118b..b6e3be0676 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt >@@ -40,6 +40,7 @@ > [% END %] > > <table> >+ <caption class="sr-only">Patrons</caption> > <tr> > <th>Num/Patrons</th> > [% FOREACH loopco IN mainloo.loopcol %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >index a1760e7a1d..6be3f2ad67 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >@@ -59,6 +59,7 @@ > [% END %] > [% END %] > <table> >+ <caption class="sr-only">Patrons statistics</caption> > <tr> > <th>[% mainloo.line | html %] / [% mainloo.column | html %]</th> > [% FOREACH loopco IN mainloo.loopcol %] >@@ -92,6 +93,7 @@ > <form method="post" action="/cgi-bin/koha/reports/borrowers_stats.pl"> > <fieldset class="rows"><legend>Patrons statistics</legend> > <table> >+ <caption class="sr-only">Patrons statistics</caption> > <thead> > <tr> > <th>Title</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >index 4ec821bc6d..42c0713370 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt >@@ -154,6 +154,7 @@ > [% IF ( do_it ) %] > <div> </div> > <table id="tbl_cash_register_stats"> >+ <caption class="sr-only">Cash register statistics</caption> > <thead> > <tr> > <th>Manager name</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt >index ecd1d44026..12978f1c99 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt >@@ -53,6 +53,7 @@ > [% END %] > > <table> >+ <caption class="sr-only">Top [% mainloo.limit | html %] Most-circulated items</caption> > <tr> <th>Rank/Biblioitemnumbers</th> > [% FOREACH loopco IN mainloo.loopcol %] > <th colspan="2">[% loopco.coltitle | html %]</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >index a1bf80f356..94399782c3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >@@ -48,8 +48,8 @@ > [% END %] > > [% IF ( mainloo.looptables ) %] >-<h2><a name="summary" id="summary"></a>Summary</h2> > <table id="summary_table"> >+<caption><a name="summary" id="summary"></a>Summary</caption> > <tr><th>Group</th><th>Call number range</th><th>Number of items displayed</th><th>Total items in group</th> > </tr> > [% FOREACH looptable IN mainloo.looptables %] >@@ -68,10 +68,8 @@ > > [% END %] > [% FOREACH looptable IN mainloo.looptables %] >-<h2><a id="table[% looptable.coltitle | html %]"></a> >- [% looptable.coltitle | html %] >-</h2> > <table> >+<caption><a id="table[% looptable.coltitle | html %]"></a>[% looptable.coltitle | html %]</caption> > <tr> > <th>#</th> > <th>Call number</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >index 5ef6f23b39..7cdaaf856f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >@@ -52,6 +52,7 @@ > [% END %] > > <table id="catalogue_stats"> >+ <caption class="sr-only">Catalog statistics</caption> > <thead> > <tr> > <th>[% mainloo.line | html %] / [% mainloo.column | html %]</th> >@@ -98,6 +99,7 @@ > <fieldset class="rows"> > <legend>Catalog statistics</legend> > <table> >+ <caption class="sr-only">Catalog statistics</caption> > <thead> > <tr> > <th>Title</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >index 69f541b271..751979ce03 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >@@ -127,6 +127,7 @@ > </form> > <br /> > <table> >+ <caption class="sr-only">Current terms</caption> > <tr> > <th>Name</th> > <th>Description</th> >@@ -304,6 +305,7 @@ > <li> > <span class="label">Data:</span> > <table> >+ <caption class="sr-only">Data</caption> > <tr> > <th>Columns</th> > <th>Values</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 135d539448..087dfa14d5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -257,6 +257,7 @@ > <form action="/cgi-bin/koha/reports/guided_reports.pl" id="reports_form" method="post"> > <input type="hidden" name="phase" value="Delete Multiple" /> > <table id="table_reports"> >+ <caption class="sr-only">Reports</caption> > <thead> > <tr> > <th class="NoSort"> </th> >@@ -592,6 +593,7 @@ > <fieldset> > <legend>Step 4 of 6: Select criteria to limit on</legend> > <table> >+ <caption class="sr-only">Select criteria to limit on</caption> > [% FOREACH criteri IN criteria %] > <tr> > <td> >@@ -648,6 +650,7 @@ > <fieldset> > <legend>Dictionary definitions</legend> > <table> >+ <caption class="sr-only">Dictionary definitions</caption> > [% FOREACH definition IN definitions %] > <tr> > <td> >@@ -681,6 +684,7 @@ > <input type="hidden" name="cache_expiry" value="[% cache_expiry | html %]" /> > <fieldset> > <table> >+ <caption class="sr-only">Pick which columns to total</caption> > [% FOREACH total_b IN total_by %] > <tr> > <td> >@@ -720,6 +724,7 @@ > <input type="hidden" name="cache_expiry" value="[% cache_expiry | html %]" /> > <fieldset> > <table> >+ <caption class="sr-only">Choose how you want the report ordered</caption> > [% FOREACH order_b IN order_by %] > <tr> > <td> >@@ -1076,6 +1081,7 @@ > <div class="pages">[% pagination_bar | $raw %]</div> > [% UNLESS ( errors ) %] > <table> >+ <caption class="sr-only">Results</caption> > <tr> > [% FOREACH header_ro IN header_row %] > <th>[% header_ro.cell | html %]</th> >@@ -1172,6 +1178,7 @@ > <h2>[% name | html %]</h2> > <p>[% notes | html %]</p> > <table> >+ <caption class="sr-only">Results</caption> > [% FOREACH rows IN saved_results %] > <tr> > [% FOREACH col IN rows %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >index 944a80abd3..89801303d1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >@@ -52,6 +52,7 @@ > [% END %] > > <table> >+ <caption class="sr-only">Average checkout period statistics results</legend> > <tr> > <th>[% mainloo.line | html %] / [% mainloo.column | html %]</th> > [% FOREACH loopco IN mainloo.loopcol %] >@@ -90,6 +91,7 @@ > <fieldset class="rows"> > <legend>Average checkout period statistics</legend> > <table> >+ <caption class="sr-only">Average checkout period statistics</legend> > <thead> > <tr> > <th>Title</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index 790ce01e2e..4a79ca039e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -81,8 +81,9 @@ > [% END %] > </ul> > [% END %] >- >- <table> >+ >+ <table> >+ <caption class="sr-only">Circulation statistics results</caption> > <tr> > <th>[% mainloo.line | html %] / [% mainloo.column | html %]</th> > [% FOREACH loopco IN mainloo.loopcol %] >@@ -112,7 +113,9 @@ > > <form method="post" action="/cgi-bin/koha/reports/issues_stats.pl"> > <fieldset class="rows"> >- <legend>Circulation statistics</legend><table> >+<legend>Circulation statistics</legend> >+ <table> >+ <caption class="sr-only">Circulation statistics</caption> > <thead> > <tr> > <th>Title</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >index 11552c85fb..42b0579341 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt >@@ -85,6 +85,7 @@ > [% END %] > > <table id="lostitems-table"> >+ <caption class="sr-only">Lost items</caption> > <thead> > <tr> > [% IF csv_profiles.count %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt >index 57fe194b5b..41c9b5977a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt >@@ -51,6 +51,7 @@ > [% FOREACH mainloo IN mainloop %] > <h1>Reports on item types [% IF branch %] held at [% Branches.GetName( branch ) | html %][% END %]</h1> > <table id="itemtypest"> >+ <caption class="sr-only">Item types</caption> > <thead> > <tr> > <th>Item type</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt >index 12ad1fde6a..f3c42fcd8d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt >@@ -51,6 +51,7 @@ > [% IF ( get_orders ) %] > > [% IF ( ordersloop ) %]<table id="funds"> >+ <caption class="sr-only">Funds</caption> > <thead> > <tr> > <th>Fund</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >index d675860db7..29219ff89d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >@@ -63,8 +63,9 @@ > [% END %] > > [% FOREACH mainloo IN mainloop %] >- >- <table> >+ >+ <table> >+ <caption class="sr-only">Holds statistics results</caption> > <tr> > <th>[% mainloo.line | html %] / [% mainloo.column | html %]</th> > [% FOREACH loopco IN mainloo.loopcol %] >@@ -97,7 +98,9 @@ > > <form method="post" action="/cgi-bin/koha/reports/reserves_stats.pl"> > <fieldset class="rows"> >- <legend>Holds statistics</legend><table> >+<legend>Holds statistics</legend> >+ <table> >+ <caption class="sr-only">Holds statistics</caption> > <thead> > <tr> > <th>Title</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >index dd7c0e23ce..24f0d7e5eb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >@@ -39,6 +39,7 @@ > <h1>Serials subscriptions</h1> > [% IF ( do_it ) %] > <table id="resulttable"> >+ <caption class="sr-only">Results</caption> > <thead> > <tr> > <th>Vendor</th> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28243
:
121750
|
121895
|
121896
|
121898
|
121899
|
121900
|
121901
|
121902
|
121903
|
121904
|
121905
|
121942
|
121943
|
121944
|
121945
|
121946
|
121947
|
121948
|
121949
| 121950 |
121956
|
121957
|
121958
|
121959
|
121973
|
121974
|
122019
|
122020
|
122021