Attachment 121953 Details for Bug 28520 – Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation"

[patch] Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation"

Bug-28520-Revert-Bug-12362-Reverse-transfer-upon-c.patch (text/plain), 2.03 KB, created by Joonas Kylmälä on 2021-06-15 05:52:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-06-15 05:52:19 UTC

Size: 2.03 KB

patch

obsolete

>From 76a606cbac30f17ff1b3a9d85c063d07d27e45f3 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Tue, 8 Jun 2021 07:50:29 +0000
>Subject: [PATCH] Bug 28520: Revert "Bug 12362: Reverse transfer upon
> cancellation"
>
>This reverts commit d0407686eb070c5bdf0302147a198027abea5ac0.
>
>This commit was part of a series adding adding reverse transfers, i.e.
>transfers that were created for transfers that were cancelled and
>we wanted the item to return back to its sending library. This however
>hid the information about transfer happening and we need another approach
>to the problem.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Item/Transfer.pm | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
>diff --git a/Koha/Item/Transfer.pm b/Koha/Item/Transfer.pm
>index 3285ec8904..03a161dc12 100644
>--- a/Koha/Item/Transfer.pm
>+++ b/Koha/Item/Transfer.pm
>@@ -18,7 +18,6 @@ package Koha::Item::Transfer;
> use Modern::Perl;
> 
> use Carp;
>-use Try::Tiny;
> 
> use C4::Items;
> 
>@@ -148,24 +147,14 @@ sub cancel {
>         error => "The 'reason' parameter is mandatory" )
>       unless defined($params->{reason});
> 
>-    my $in_transit = $self->in_transit;
>-
>     # Throw exception if item is in transit already
>-    Koha::Exceptions::Item::Transfer::InTransit->throw() if ( !$params->{force} && $in_transit );
>+    Koha::Exceptions::Item::Transfer::InTransit->throw() if ( !$params->{force} && $self->in_transit );
> 
>     # Update the cancelled date
>     $self->set(
>         { datecancelled => dt_from_string, cancellation_reason => $params->{reason} } )
>       ->store;
> 
>-    # Set up return transfer if transfer was force cancelled whilst in transit
>-    # NOTE: We don't catch here, as we're happy to fail if there are already
>-    # other transfers in the queue.
>-    try {
>-        $self->item->request_transfer(
>-            { to => $self->from_library, reason => 'TransferCancellation' } );
>-    };
>-
>     return $self;
> }
> 
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 28520: 121686 | 121689 | 121690 | 121691 | 121693 | 121708 | 121709 | 121710 | 121711 | 121712 | 121718 | 121719 | 121720 | 121721 | 121722 | 121843 | 121844 | 121845 | 121846 | 121847 | 121951 | 121952 | 121953 | 121954 | 121955 | 121985 | 122005 | 122006 | 122007