Attachment 121985 Details for Bug 28520 – Bug 28520: Remove tests for removed from_library function

[patch] Bug 28520: Remove tests for removed from_library function

Bug-28520-Remove-tests-for-removed-fromlibrary-fun.patch (text/plain), 1.70 KB, created by Joonas Kylmälä on 2021-06-15 10:14:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-06-15 10:14:28 UTC

Size: 1.70 KB

patch

obsolete

>From 2339632815d49433494952f2b1f6af7aedd47ad9 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Tue, 15 Jun 2021 13:12:14 +0300
>Subject: [PATCH] Bug 28520: Remove tests for removed from_library function
>
>The function was unused and removed.
>---
> t/db_dependent/Koha/Item/Transfer.t | 24 +-----------------------
> 1 file changed, 1 insertion(+), 23 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Item/Transfer.t b/t/db_dependent/Koha/Item/Transfer.t
>index 54b8208419..c0cc762105 100755
>--- a/t/db_dependent/Koha/Item/Transfer.t
>+++ b/t/db_dependent/Koha/Item/Transfer.t
>@@ -24,7 +24,7 @@ use Koha::DateUtils;
> 
> use t::lib::TestBuilder;
> 
>-use Test::More tests => 7;
>+use Test::More tests => 6;
> use Test::Exception;
> 
> my $schema  = Koha::Database->new->schema;
>@@ -52,28 +52,6 @@ subtest 'item relation tests' => sub {
>     $schema->storage->txn_rollback;
> };
> 
>-subtest 'from_library relation tests' => sub {
>-    plan tests => 2;
>-
>-    $schema->storage->txn_begin;
>-
>-    my $library = $builder->build_object( { class => 'Koha::Libraries' } );
>-    my $transfer = $builder->build_object(
>-        {
>-            class => 'Koha::Item::Transfers',
>-            value => {
>-                frombranch => $library->branchcode,
>-            }
>-        }
>-    );
>-
>-    my $from_library = $transfer->from_library;
>-    is( ref( $from_library ), 'Koha::Library', 'Koha::Item::Transfer->from_library should return a Koha::Library' );
>-    is( $from_library->branchcode, $library->branchcode, 'Koha::Item::Transfer->from_library should return the correct library' );
>-
>-    $schema->storage->txn_rollback;
>-};
>-
> subtest 'to_library relation tests' => sub {
>     plan tests => 2;
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28520: 121686 | 121689 | 121690 | 121691 | 121693 | 121708 | 121709 | 121710 | 121711 | 121712 | 121718 | 121719 | 121720 | 121721 | 121722 | 121843 | 121844 | 121845 | 121846 | 121847 | 121951 | 121952 | 121953 | 121954 | 121955 | 121985 | 122005 | 122006 | 122007