Attachment 122039 Details for Bug 28571 – Bug 28571: Remove C4::Auth::_session_log

[patch] Bug 28571: Remove C4::Auth::_session_log

Bug-28571-Remove-C4Authsessionlog.patch (text/plain), 2.19 KB, created by Jonathan Druart on 2021-06-16 13:28:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-06-16 13:28:49 UTC

Size: 2.19 KB

patch

obsolete

>From 04d76d1b55e7ab99ee42200e513a0b9d81b77ffc Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 16 Jun 2021 15:28:01 +0200
>Subject: [PATCH] Bug 28571: Remove C4::Auth::_session_log
>
>It's not used and must be removed
>
>Test plan:
>  % git grep _session_log
>must not return any result.
>---
> C4/Auth.pm | 11 -----------
> 1 file changed, 11 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index cb35984b2ef..9441e745ee2 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -804,13 +804,6 @@ sub _version_check {
>     }
> }
> 
>-sub _session_log {
>-    (@_) or return 0;
>-    open my $fh, '>>', "/tmp/sessionlog" or warn "ERROR: Cannot append to /tmp/sessionlog";
>-    printf $fh join( "\n", @_ );
>-    close $fh;
>-}
>-
> sub _timeout_syspref {
>     my $default_timeout = 600;
>     my $timeout = C4::Context->preference('timeout') || $default_timeout;
>@@ -953,7 +946,6 @@ sub checkauth {
>             $session->flush;
>             C4::Context->_unset_userenv($sessionID);
> 
>-            #_session_log(sprintf "%20s from %16s logged out at %30s (manually).\n", $userid,$ip,(strftime "%c",localtime));
>             $sessionID = undef;
>             $userid    = undef;
> 
>@@ -976,7 +968,6 @@ sub checkauth {
>             }
>             C4::Context->_unset_userenv($sessionID);
> 
>-            #_session_log(sprintf "%20s from %16s logged out at %30s (inactivity).\n", $userid,$ip,(strftime "%c",localtime));
>             $userid    = undef;
>             $sessionID = undef;
>         }
>@@ -990,7 +981,6 @@ sub checkauth {
>             $session->flush;
>             C4::Context->_unset_userenv($sessionID);
> 
>-            #_session_log(sprintf "%20s from %16s logged out at %30s (ip changed to %16s).\n", $userid,$ip,(strftime "%c",localtime), $info{'newip'});
>             $sessionID = undef;
>             $userid    = undef;
>         }
>@@ -1151,7 +1141,6 @@ sub checkauth {
>             # $return: 1 = valid user
>             if ($return) {
> 
>-                #_session_log(sprintf "%20s from %16s logged in  at %30s.\n", $userid,$ENV{'REMOTE_ADDR'},(strftime '%c', localtime));
>                 if ( $flags = haspermission( $userid, $flagsrequired ) ) {
>                     $loggedin = 1;
>                 }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28571: 122039 | 122173 | 122342