Bugzilla – Attachment 122144 Details for
Bug 12561
Remove non-XSLT views
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12561: Add warning on about page
Bug-12561-Add-warning-on-about-page.patch (text/plain), 4.28 KB, created by
Jonathan Druart
on 2021-06-18 14:22:51 UTC
(
hide
)
Description:
Bug 12561: Add warning on about page
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-06-18 14:22:51 UTC
Size:
4.28 KB
patch
obsolete
>From 7253a94218d111b1289addaff3c67c9982e6f8a7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 18 Jun 2021 16:13:17 +0200 >Subject: [PATCH] Bug 12561: Add warning on about page > >If a default xslt file has been removed or if the one filled in one of >the syspref does not exist. >--- > about.pl | 25 +++++++++++++++++++ > .../intranet-tmpl/prog/en/modules/about.tt | 7 +++++- > 2 files changed, 31 insertions(+), 1 deletion(-) > >diff --git a/about.pl b/about.pl >index 32547afec1e..e5831be1045 100755 >--- a/about.pl >+++ b/about.pl >@@ -326,6 +326,31 @@ if ( C4::Context->preference('ILLModule') ) { > $template->param( warnILLConfiguration => $warnILLConfiguration ); > } > >+{ >+ # XSLT sysprefs >+ my @xslt_prefs = qw( >+ OPACXSLTDetailsDisplay >+ OPACXSLTListsDisplay >+ OPACXSLTResultsDisplay >+ XSLTDetailsDisplay >+ XSLTListsDisplay >+ XSLTResultsDisplay >+ ); >+ my @warnXSLT; >+ for my $p ( @xslt_prefs ) { >+ my $xsl_filename = C4::XSLT::get_xsl_filename( $p ); >+ next if -e $xsl_filename; >+ push @warnXSLT, >+ { >+ syspref => $p, >+ value => C4::Context->preference("$p"), >+ filename => $xsl_filename >+ }; >+ } >+ >+ $template->param( warnXSLT => \@warnXSLT ) if @warnXSLT; >+} >+ > if ( C4::Context->preference('SearchEngine') eq 'Elasticsearch' ) { > # Check ES configuration health and runtime status > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index e9d71c03557..7a12ed04419 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -299,7 +299,7 @@ > Contact your system administrator. > [% END %] > >- [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size %] >+ [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || warnXSLT || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size %] > <h2>Warnings regarding the system configuration</h2> > <table> > <caption>Preferences and parameters</caption> >@@ -327,6 +327,11 @@ > [% IF warnPrefOpacHiddenItems %] > <tr><th scope="row"><strong>Warning</strong> </th><td>System preference 'OpacHiddenItems' generates a warning and will produce unexpected behaviors: [% warnPrefOpacHiddenItems | html %]</th></tr> > [% END %] >+ [% IF warnXSLT %] >+ [% FOR p IN warnXSLT %] >+ <tr><th scope="row"><strong>Warning</strong> </th><td>System preference '[% p.syspref | html %]' is '[% p.value | html %]', but the file '[% p.filename | html %]' does not exist.</th></tr> >+ [% END %] >+ [% END %] > [% IF invalid_yesno.count %] > [% FOR p IN invalid_yesno %] > <tr><th scope="row"><strong>Warning</strong> </th><td>System preference '[% p.variable | html %]' must be '0' or '1', but is [% IF p.value.defined %]'[% p.value | html%]'[% ELSE %]NULL[% END %].</td></tr> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12561
:
122141
|
122142
|
122143
|
122144
|
122600
|
122601
|
122607
|
122608
|
122609
|
122610
|
123262
|
123263
|
123264
|
123265
|
123267
|
123268
|
123269
|
123270
|
123300
|
123301
|
123302
|
123303
|
123305
|
123306
|
123307
|
123308