Bugzilla – Attachment 122145 Details for
Bug 28570
bor_issues_top.pl using a /tmp file to log debug
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28570: Remove log to /tmp file from bor_issues_top.pl
Bug-28570-Remove-log-to-tmp-file-from-borissuestop.patch (text/plain), 3.38 KB, created by
Martin Renvoize (ashimema)
on 2021-06-18 14:27:43 UTC
(
hide
)
Description:
Bug 28570: Remove log to /tmp file from bor_issues_top.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-06-18 14:27:43 UTC
Size:
3.38 KB
patch
obsolete
>From 1b0facc789a942ee87ab4896ef36a95ec32ba1f2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 16 Jun 2021 15:24:31 +0200 >Subject: [PATCH] Bug 28570: Remove log to /tmp file from bor_issues_top.pl > >This is unusual and must not be done. >Removing it. > >Test plan: >Use the "Home > Reports > Patrons with the most checkouts" report and >confirm that it is working correctly after you applied this patch > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > reports/bor_issues_top.pl | 14 -------------- > 1 file changed, 14 deletions(-) > >diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl >index 265362bb0d..d69cac025d 100755 >--- a/reports/bor_issues_top.pl >+++ b/reports/bor_issues_top.pl >@@ -27,7 +27,6 @@ use C4::Koha; > use C4::Circulation; > use C4::Members; > use C4::Reports; >-use C4::Debug; > > use Koha::DateUtils; > use Koha::ItemTypes; >@@ -41,8 +40,6 @@ plugin that shows a stats on borrowers > > =cut > >-$debug and open my $debugfh, '>', '/tmp/bor_issues_top.debug.log'; >- > my $input = CGI->new; > my $fullreportname = "reports/bor_issues_top.tt"; > my $do_it = $input->param('do_it'); >@@ -223,25 +220,20 @@ sub calculate { > $strsth2 .=" GROUP BY $colfield"; > $strsth2 .=" ORDER BY $colorder"; > >- $debug and print $debugfh "bor_issues_top (old_issues) SQL: $strsth2\n"; > my $sth2 = $dbh->prepare($strsth2); > $sth2->execute; >- print $debugfh "rows: ", $sth2->rows, "\n"; > while (my @row = $sth2->fetchrow) { > $columns{($row[0] ||'NULL')}++; > push @loopcol, { coltitle => $row[0] || 'NULL' }; > } > > $strsth2 =~ s/old_issues/issues/g; >- $debug and print $debugfh "bor_issues_top (issues) SQL: $strsth2\n"; > $sth2 = $dbh->prepare($strsth2); > $sth2->execute; >- $debug and print $debugfh "rows: ", $sth2->rows, "\n"; > while (my @row = $sth2->fetchrow) { > $columns{($row[0] ||'NULL')}++; > push @loopcol, { coltitle => $row[0] || 'NULL' }; > } >- $debug and print $debugfh "full array: ", Dumper(\%columns), "\n"; > }else{ > $columns{''} = 1; > } >@@ -278,10 +270,8 @@ sub calculate { > $strcalc .= ",$colfield " if ($colfield); > $strcalc .= " LIMIT $limit" if ($limit); > >- $debug and print $debugfh "(old_issues) SQL : $strcalc\n"; > my $dbcalc = $dbh->prepare($strcalc); > $dbcalc->execute; >- $debug and print $debugfh "rows: ", $dbcalc->rows, "\n"; > my %patrons = (); > # DATA STRUCTURE is going to look like this: > # (2253=> {name=>"John Doe", >@@ -300,10 +290,8 @@ sub calculate { > use Data::Dumper; > > $strcalc =~ s/old_issues/issues/g; >- $debug and print $debugfh "(issues) SQL : $strcalc\n"; > $dbcalc = $dbh->prepare($strcalc); > $dbcalc->execute; >- $debug and print $debugfh "rows: ", $dbcalc->rows, "\n"; > while (my @data = $dbcalc->fetchrow) { > my ($row, $rank, $id, $col) = @data; > $col = "zzEMPTY" if (!defined($col)); >@@ -322,7 +310,6 @@ sub calculate { > $patrons{$id}->{total} += $count; > } > } >- $debug and print $debugfh "\n\npatrons: ", Dumper(\%patrons); > > my $i = 1; > my @cols_in_order = sort keys %columns; # if you want to order the columns, do something here >@@ -368,6 +355,5 @@ sub calculate { > return [\%globalline]; # reference to a 1 element array: that element is a hashref > } > >-$debug and close $debugfh; > 1; > __END__ >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28570
:
122038
|
122145
|
122163