Attachment 122214 Details for Bug 28511 – Bug 28511: Road types in OPAC should prefer OPAC description if one exists

[patch] Bug 28511: Road types in OPAC should prefer OPAC description if one exists

Bug-28511-Road-types-in-OPAC-should-prefer-OPAC-de.patch (text/plain), 2.67 KB, created by Jonathan Druart on 2021-06-21 10:00:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-06-21 10:00:36 UTC

Size: 2.67 KB

patch

obsolete

>From 4c958c5ae05d87c3e55c4493dd5a031ecd24c479 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 7 Jun 2021 18:47:25 +0000
>Subject: [PATCH] Bug 28511: Road types in OPAC should prefer OPAC description
> if one exists
>
>This patch modifies the patron entry form in the OPAC so that if street
>types are defined in authorized values, the OPAC description is
>preferred.
>
>To test, apply the patch and go to Administration -> Authorized values.
>
>- Add or edit entries in the "ROADTYPE" category.
>  - Some entries should have only the "Description" set, while others
>    should have "Description" and "Description (OPAC)".
>- In the OPAC, open the patron registration page. Check the "Stree type"
>  drop down in the "Main address" section.
>  - For entries which have an OPAC description, this value should show.
>  - For entries without an OPAC description the default should show.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index c452dc37e24..bfb44510aab 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -435,9 +435,9 @@
>                                                         <option value=""></option>
>                                                         [% FOR roadtype IN roadtypes %]
>                                                             [% IF roadtype.authorised_value == patron.streettype %]
>-                                                                <option value="[% roadtype.authorised_value | html %]" selected="selected">[% roadtype.lib | html %]</option>
>+                                                                <option value="[% roadtype.authorised_value | html %]" selected="selected">[% roadtype.lib_opac OR roadtype.lib | html %]</option>
>                                                             [% ELSE %]
>-                                                                <option value="[% roadtype.authorised_value | html %]">[% roadtype.lib | html %]</option>
>+                                                                <option value="[% roadtype.authorised_value | html %]">[% roadtype.lib_opac OR roadtype.lib | html %]</option>
>                                                             [% END %]
>                                                         [% END %]
>                                                     </select>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28511: 121692 | 121696 | 121863 | 122214