Bugzilla – Attachment 122277 Details for
Bug 28514
Replace C4::Letters::getletter with Koha::Notice::Templates->find_effective_template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28514: Set lang to default is not passed
Bug-28514-Set-lang-to-default-is-not-passed.patch (text/plain), 1.16 KB, created by
Jonathan Druart
on 2021-06-22 09:57:49 UTC
(
hide
)
Description:
Bug 28514: Set lang to default is not passed
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-06-22 09:57:49 UTC
Size:
1.16 KB
patch
obsolete
>From dda6392c303a6822197af1993c5b3bf14f288d14 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 22 Jun 2021 11:57:00 +0200 >Subject: [PATCH] Bug 28514: Set lang to default is not passed > >It fixes the following test: > # Failed test 'no lang passed, default is returned' > # at t/db_dependent/Koha/Notices.t line 105. > # got: 'es-ES' > # expected: 'default' > # Looks like you failed 1 test of 7. >--- > Koha/Notice/Templates.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/Koha/Notice/Templates.pm b/Koha/Notice/Templates.pm >index 6abc1b36d34..8105f975680 100644 >--- a/Koha/Notice/Templates.pm >+++ b/Koha/Notice/Templates.pm >@@ -59,7 +59,9 @@ sub find_effective_template { > my ( $self, $params ) = @_; > > $params = { %$params }; # don't modify original >- $params->{lang} = 'default' unless C4::Context->preference('TranslateNotices'); >+ >+ $params->{lang} = 'default' >+ unless C4::Context->preference('TranslateNotices') && $params->{lang}; > > my $only_my_library = C4::Context->only_my_library; > if ( $only_my_library and $params->{branchcode} ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28514
:
121628
|
121727
|
122055
|
122224
|
122225
| 122277