Bugzilla – Attachment 122283 Details for
Bug 28516
Koha/Patrons/Import.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28516: Prevent failures if borrower_attribute_types.mandatory=1
Bug-28516-Prevent-failures-if-borrowerattributetyp.patch (text/plain), 1.32 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-06-22 13:32:05 UTC
(
hide
)
Description:
Bug 28516: Prevent failures if borrower_attribute_types.mandatory=1
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-06-22 13:32:05 UTC
Size:
1.32 KB
patch
obsolete
>From f9030bd27a8ab40c70200064f3a31655fed8ea5e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 4 Jun 2021 15:36:59 +0200 >Subject: [PATCH] Bug 28516: Prevent failures if > borrower_attribute_types.mandatory=1 > >TestBuilder will generate an integer for the >Koha::Patron::Attribute::Type object, but if 1 is picked some tests are >failing randomly >At least t/db_dependent/Koha/Patrons.t and t/db_dependent/Koha/Patrons/Import.t >The expection "Missing mandatory extended attribute" is raised when the >patron is stored. > >Test plan: >The following script should return 0 when the patch is applied: > >""" >use t::lib::TestBuilder; >my $builder = t::lib::TestBuilder->new; >my $x = $builder->build_object( > { > class => 'Koha::Patron::Attribute::Types', > } >); >say $x->mandatory; >""" > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/lib/TestBuilder.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index d8897b8145..ee375425af 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -592,7 +592,10 @@ sub _gen_default_values { > }, > AuthHeader => { > marcxml => '', >- } >+ }, >+ BorrowerAttributeType => { >+ mandatory => 0, >+ }, > }; > } > >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28516
:
121631
| 122283