Bugzilla – Attachment 122310 Details for
Bug 28616
Remove Data::Printer dependency
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28616: (bug 28220 follow-up) Replace Data::Printer with simple warn
Bug-28616-bug-28220-follow-up-Replace-DataPrinter-.patch (text/plain), 1.45 KB, created by
Jonathan Druart
on 2021-06-23 07:41:49 UTC
(
hide
)
Description:
Bug 28616: (bug 28220 follow-up) Replace Data::Printer with simple warn
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-06-23 07:41:49 UTC
Size:
1.45 KB
patch
obsolete
>From 45d2546842b9cb76ae5c4b6d165a8442f36faf86 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 23 Jun 2021 09:40:36 +0200 >Subject: [PATCH] Bug 28616: (bug 28220 follow-up) Replace Data::Printer with > simple warn > >$_ is an exception that will be stringify in scalar context. We don't >need Data::Printer here. >--- > Koha/Patrons/Import.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index e6c59eab487..9347d037816 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -349,7 +349,7 @@ sub import_patrons { > } elsif ( $_->isa('Koha::Exceptions::Patron::Attribute::NonRepeatable') ) { > push @errors, { patron_attribute_non_repeatable => 1, borrowernumber => $borrowernumber, attribute => $_->attribute }; > } else { >- use Data::Printer colored => 1; warn p $_; >+ warn $_; > push @errors, { unknown_error => 1 }; > } > >@@ -417,7 +417,7 @@ sub import_patrons { > push @errors, { patron_attribute_non_repeatable => 1, patron_id => $patron_id, attribute => $_->attribute }; > > } else { >- use Data::Printer colored => 1; warn p $_; >+ warn $_; > push @errors, { unknown_error => 1 }; > } > push( >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28616
:
122308
| 122310