Attachment 122357 Details for Bug 28624 – Bug 28624: Remove Smart::Comments

[patch] Bug 28624: Remove Smart::Comments

Bug-28624-Remove-SmartComments.patch (text/plain), 2.70 KB, created by Jonathan Druart on 2021-06-24 07:49:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-06-24 07:49:14 UTC

Size: 2.70 KB

patch

obsolete

>From ae006a34ac7155b43e9bf7f705e118e32251fb43 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 24 Jun 2021 09:44:33 +0200
>Subject: [PATCH] Bug 28624: Remove Smart::Comments
>
>It's not used in those files (there is no occurrence of ###), and it's
>not installed anyway (it is by koha-testing-docker however).
>
>We should remove those lines.
>
>Test plan:
>Confirm the above
>---
> about.pl                    | 3 ---
> admin/preferences.pl        | 3 ---
> labels/spinelabel-home.pl   | 2 --
> members/printslip.pl        | 3 ---
> members/update-child.pl     | 2 --
> serials/subscription-add.pl | 2 --
> 6 files changed, 15 deletions(-)
>
>diff --git a/about.pl b/about.pl
>index 3320b36b812..cee56187bb7 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -58,9 +58,6 @@ use Koha::Filter::MARC::ViewPolicy;
> 
> use C4::Members::Statistics;
> 
>-
>-#use Smart::Comments '####';
>-
> my $query = CGI->new;
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {
>diff --git a/admin/preferences.pl b/admin/preferences.pl
>index f3879d7cb93..b620d8e1432 100755
>--- a/admin/preferences.pl
>+++ b/admin/preferences.pl
>@@ -35,9 +35,6 @@ use YAML::XS;
> use Encode;
> use List::MoreUtils qw(any);
> 
>-# use Smart::Comments;
>-#
>-
> sub GetTab {
>     my ( $input, $tab ) = @_;
> 
>diff --git a/labels/spinelabel-home.pl b/labels/spinelabel-home.pl
>index 3648670af20..30fc798b03d 100755
>--- a/labels/spinelabel-home.pl
>+++ b/labels/spinelabel-home.pl
>@@ -21,8 +21,6 @@ use C4::Auth;
> use C4::Output;
> use C4::Context;
> 
>-# use Smart::Comments;
>-
> my $query = CGI->new;
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {   template_name   => "labels/spinelabel-home.tt",
>diff --git a/members/printslip.pl b/members/printslip.pl
>index 58a41adeb74..2e861392026 100755
>--- a/members/printslip.pl
>+++ b/members/printslip.pl
>@@ -41,9 +41,6 @@ use C4::Members;
> use C4::Koha;
> use Koha::DateUtils;
> 
>-#use Smart::Comments;
>-#use Data::Dumper;
>-
> use vars qw($debug);
> 
> BEGIN {
>diff --git a/members/update-child.pl b/members/update-child.pl
>index d2f9c49e3ad..496214f7f6a 100755
>--- a/members/update-child.pl
>+++ b/members/update-child.pl
>@@ -35,8 +35,6 @@ use Koha::Patrons;
> use Koha::Patron::Categories;
> use Koha::Patrons;
> 
>-# use Smart::Comments;
>-
> my $dbh   = C4::Context->dbh;
> my $input = CGI->new;
> 
>diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl
>index 96891487bc1..0cec5d083bb 100755
>--- a/serials/subscription-add.pl
>+++ b/serials/subscription-add.pl
>@@ -39,8 +39,6 @@ use Koha::Subscription::Numberpattern;
> use Koha::Subscription::Frequency;
> use Koha::SharedContent;
> 
>-#use Smart::Comments;
>-
> our $query = CGI->new;
> my $op = $query->param('op') || '';
> my $dbh = C4::Context->dbh;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28624: 122357 | 122602 | 122742 | 122868