Bugzilla – Attachment 122398 Details for
Bug 22544
Move C4:NewsChannels to Koha namespace
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22544: Move del_opac_new to Koha namespace
Bug-22544-Move-delopacnew-to-Koha-namespace.patch (text/plain), 2.01 KB, created by
Marcel de Rooy
on 2021-06-25 07:04:57 UTC
(
hide
)
Description:
Bug 22544: Move del_opac_new to Koha namespace
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-06-25 07:04:57 UTC
Size:
2.01 KB
patch
obsolete
>From 8969997180b2dfe700cbcedf11faead35b0f3ee6 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 19 Mar 2019 10:23:40 +0000 >Subject: [PATCH] Bug 22544: Move del_opac_new to Koha namespace >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/NewsChannels.pm | 24 +----------------------- > tools/koha-news.pl | 2 +- > 2 files changed, 2 insertions(+), 24 deletions(-) > >diff --git a/C4/NewsChannels.pm b/C4/NewsChannels.pm >index 0917a67ae4..2126b40184 100644 >--- a/C4/NewsChannels.pm >+++ b/C4/NewsChannels.pm >@@ -30,7 +30,7 @@ BEGIN { > @ISA = qw(Exporter); > @EXPORT = qw( > &GetNewsToDisplay >- &add_opac_new &upd_opac_new &del_opac_new >+ &add_opac_new &upd_opac_new > ); > } > >@@ -123,28 +123,6 @@ sub upd_opac_new { > return $retval; > } > >-sub del_opac_new { >- my ($ids) = @_; >- if ($ids) { >- >- #Log news deletion >- if (C4::Context->preference("NewsLog")) { >- foreach my $newsid ( split(/,/, $ids )) { >- my $n = Koha::News->find( $newsid ); >- logaction('NEWS', 'DELETE', undef, $n->unblessed->{lang} . ' | ' . $n->unblessed->{content} ); >- } >- } >- >- my $dbh = C4::Context->dbh; >- my $sth = $dbh->prepare("DELETE FROM opac_news WHERE idnew IN ($ids)"); >- $sth->execute(); >- return 1; >- } else { >- return 0; >- } >- >-} >- > =head2 GetNewsToDisplay > > $news = &GetNewsToDisplay($lang,$branch); >diff --git a/tools/koha-news.pl b/tools/koha-news.pl >index e8d72f1c48..ab6c89c5d4 100755 >--- a/tools/koha-news.pl >+++ b/tools/koha-news.pl >@@ -143,7 +143,7 @@ elsif ( $op eq 'edit' ) { > } > elsif ( $op eq 'del' ) { > my @ids = $cgi->multi_param('ids'); >- del_opac_new( join ",", @ids ); >+ Koha::News->search({ idnew => @ids })->delete; > print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl"); > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22544
:
86772
|
86773
|
86774
|
86775
|
86776
|
86777
|
86780
|
86781
|
90103
|
90104
|
90105
|
90106
|
90107
|
90108
|
90109
|
90110
|
92005
|
92006
|
92007
|
92008
|
92009
|
92010
|
92011
|
92012
|
95613
|
95614
|
95615
|
95627
|
95628
|
95629
|
95630
|
95631
|
95632
|
95633
|
95634
|
99849
|
99850
|
99851
|
99852
|
99853
|
99854
|
99855
|
99856
|
99857
|
104176
|
104177
|
104178
|
104179
|
104180
|
104181
|
104182
|
104183
|
104184
|
111012
|
111013
|
111014
|
111015
|
111016
|
111017
|
111018
|
111019
|
111020
|
111021
|
111022
|
111023
|
115135
|
115136
|
115137
|
115138
|
115139
|
115140
|
115141
|
115142
|
115143
|
115144
|
115145
|
115146
|
115218
|
115296
|
115297
|
115298
|
115299
|
116933
|
116934
|
116935
|
117479
|
117480
|
117481
|
117482
|
117483
|
117484
|
117485
|
117486
|
117487
|
117488
|
117489
|
117490
|
117491
|
117492
|
117493
|
117494
|
117495
|
117496
|
117497
|
118054
|
118055
|
118056
|
118057
|
118058
|
118059
|
118060
|
118061
|
118062
|
118063
|
118064
|
118065
|
118066
|
118067
|
118068
|
118069
|
118070
|
118071
|
118072
|
118073
|
118087
|
118088
|
118089
|
118090
|
118091
|
118092
|
118093
|
118094
|
118095
|
118096
|
118097
|
118098
|
118099
|
118100
|
118101
|
118102
|
118103
|
118104
|
118105
|
118106
|
120377
|
120378
|
120379
|
120380
|
120381
|
120382
|
120383
|
120384
|
120385
|
120386
|
120387
|
120388
|
120389
|
120390
|
120391
|
120392
|
120393
|
120394
|
120395
|
120396
|
122396
|
122397
| 122398 |
122399
|
122400
|
122401
|
122402
|
122403
|
122404
|
122405
|
122406
|
122407
|
122408
|
122409
|
122410
|
122411
|
122412
|
122413
|
122414
|
122415