Attachment 122466 Details for Bug 26302 – Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too

[patch] Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too

Bug-26302-Apply-resultsMaxItemsUnavailable-to-the-.patch (text/plain), 2.71 KB, created by David Nind on 2021-06-26 23:18:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-06-26 23:18:10 UTC

Size: 2.71 KB

patch

obsolete

>From b0f0fb6e23d5816cc3cd2f1b2279445469cf3557 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 24 Jun 2021 14:26:21 +0000
>Subject: [PATCH] Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too
>
>Test plan:
>Add some not for loan categories, add some items for them.
>Check search results. Verify that results match expectation.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Tested the combination of pref values for results 2/1 with NFL categories TEST, MOVING:
>    Availability: Items available for loan: Centerville (3) [Call number: PERL A 2, PERL A 3, ...] Items available for reference: Centerville Staff Collection (1) [Call number: PERL A 10]. Not available: TEST (2) [ PERL A 11, .. ]. MOVING (1) [ PERL A 13 ]. Withdrawn (2) [ PERL A 5, .. ]. Damaged (3) [ PERL A 7, .. ].
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl       | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>index 0cf3f62a51..35b3eeb3e4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>@@ -1407,11 +1407,11 @@
>                         <xsl:variable name="unavailable_items" select="key('item-by-status', 'reallynotforloan')"/>
>                         <xsl:for-each select="$unavailable_items[not(./items:substatus=preceding-sibling::*/items:substatus)]">
>                             <span class="ItemSummary unavailable">
>-                                <span class='notforloandesc'><xsl:value-of select="items:substatus"/></span>
>-                                <xsl:text> (</xsl:text>
>-                                <xsl:value-of select="count(parent::*/items:item/items:substatus[ text() = current()/items:substatus  ])"/>
>-                                <xsl:text>)</xsl:text>
>-                                <xsl:choose><xsl:when test="position()=last()"><xsl:text>. </xsl:text></xsl:when><xsl:otherwise><xsl:text>, </xsl:text></xsl:otherwise></xsl:choose>
>+                                <xsl:call-template name="listCallNumbers">
>+                                    <xsl:with-param name="status_text" select="items:substatus"/>
>+                                    <xsl:with-param name="items" select="$unavailable_items[./items:substatus=current()/items:substatus]"/>
>+                                    <xsl:with-param name="max" select="$resultsMaxItemsUnavailable"/>
>+                                </xsl:call-template>
>                             </span>
>                         </xsl:for-each>
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26302: 109184 | 119108 | 119109 | 119110 | 119111 | 122386 | 122387 | 122388 | 122389 | 122391 | 122462 | 122463 | 122464 | 122465 | 122466 | 122487 | 123499 | 123500 | 123501 | 123502 | 123526 | 123527 | 123528 | 123529 | 123531 | 123532 | 123533 | 123534 | 123640 | 123641 | 123643 | 123644 | 123645 | 123646 | 123647 | 123648 | 123649 | 124243 | 124244 | 124245