Bugzilla – Attachment 12250 Details for
Bug 8559
conflicting item statuses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8559 - Conflicting item statuses - Force cancel waiting hold
Bug-8559---Conflicting-item-statuses---Force-cance.patch (text/plain), 1.90 KB, created by
Kyle M Hall (khall)
on 2012-09-14 18:46:17 UTC
(
hide
)
Description:
Bug 8559 - Conflicting item statuses - Force cancel waiting hold
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-09-14 18:46:17 UTC
Size:
1.90 KB
patch
obsolete
>From d67dbfde1d097ba59464b0fa89fdaadf3c004eb5 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 14 Sep 2012 14:43:04 -0400 >Subject: [PATCH] Bug 8559 - Conflicting item statuses - Force cancel waiting hold >Content-Type: text/plain; charset="utf-8" > >If you check out a waiting hold to a different patron it >gives the item conflicting statuses. It will both be checked out >for one patron, and also waiting for a different patron. > >This patch solves the problem by forcing the librarian to cancel the >hold if they inist on checking the item out to a different patron. >--- > .../prog/en/modules/circ/circulation.tt | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index c95002d..8d29796 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -370,14 +370,18 @@ function validate1(date) { > > [% IF ( RESERVED ) %] > <p> >- <input type="checkbox" id="cancelreserve" name="cancelreserve" value="1" /> >+ <input type="checkbox" id="cancelreserve" name="cancelreserve" value="1" checked="checked" /> > <label for="cancelreserve">Cancel hold</label> > </p> > [% END %] > > [% IF ( RESERVE_WAITING ) %] > <p> >- <input type="checkbox" id="cancelreserve" name="cancelreserve" value="1" /> >+ [%# We *must* cancel waiting holds when overriding, see bug 8559 %] >+ [%# This checkbox is just a visual cue that the hold will be canceled %] >+ <input type="checkbox" checked="checked" disabled="disabled"/> >+ [%# This hidden input actually does the deed of canceling the waiting reserve %] >+ <input type="hidden" id="cancelreserve" name="cancelreserve" value="1"/> > <label for="cancelreserve">Cancel hold</label> > </p> > [% END %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8559
:
11293
|
12249
|
12250
|
12252
|
12275
|
12276
|
12279
|
12281
|
12679
|
13668
|
13669