Attachment 122539 Details for Bug 26346 – Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user

[patch] Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user

Bug-26364-QA-follow-up-Do-not-crash-on-anonymous-O.patch (text/plain), 1.06 KB, created by Alex Buckley on 2021-07-02 11:17:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2021-07-02 11:17:26 UTC

Size: 1.06 KB

patch

obsolete

>From fea2e869bad17a3115c92b26e1a010795e9533d7 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 2 Jul 2021 08:59:25 +0000
>Subject: [PATCH] Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user
>
>Seriously!
>Can't call method "userid" on an undefined value at /usr/share/koha/Koha/Virtualshelf.pm line 253
>Trivial fix.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>https://bugs.koha-community.org/show_bug.cgi?id=26346
>---
> Koha/Virtualshelf.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Virtualshelf.pm b/Koha/Virtualshelf.pm
>index 66ae4beb68..676791ff02 100644
>--- a/Koha/Virtualshelf.pm
>+++ b/Koha/Virtualshelf.pm
>@@ -249,7 +249,7 @@ sub can_be_managed {
>     return 1
>       if $borrowernumber and $self->owner == $borrowernumber;
> 
>-    my $patron = Koha::Patrons->find( $borrowernumber );
>+    my $patron = Koha::Patrons->find( $borrowernumber ) or return 0;
>     return 1
>       if $self->is_public and haspermission( $patron->userid, { lists => 'edit_public_lists' } );
>     return 0;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26346: 119686 | 120663 | 120664 | 120665 | 120909 | 120910 | 120953 | 120954 | 121511 | 121512 | 122033 | 122034 | 122533 | 122535 | 122536 | 122537 | 122538 | 122539 | 122540 | 122685 | 122686 | 122687 | 122688 | 122689 | 122691 | 124010 | 124011 | 125436 | 125472 | 125914 | 125915 | 125916 | 125917 | 127556 | 127557 | 127558 | 127559 | 127560 | 128017 | 128018 | 128019 | 128020 | 128021 | 128022 | 128023 | 128383 | 128384 | 128385 | 131699 | 131700 | 131757 | 131764 | 132373 | 132475 | 132476 | 132477 | 132478 | 132479 | 132751 | 132752 | 132753 | 132754 | 132755