Attachment 122541 Details for Bug 28472 – Bug 28472: handle items with NULL shelving location

[patch] Bug 28472: handle items with NULL shelving location

Bug-28472-handle-items-with-NULL-shelving-location.patch (text/plain), 2.05 KB, created by Andreas Roussos on 2021-07-02 11:34:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Roussos

Created: 2021-07-02 11:34:51 UTC

Size: 2.05 KB

patch

obsolete

>From ae0468e08b4771b5d42ec0447fe486728ed19b5d Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <a.roussos@dataly.gr>
>Date: Fri, 2 Jul 2021 13:12:21 +0200
>Subject: [PATCH] Bug 28472: handle items with NULL shelving location
>
>The UpdateItemLocationOnCheckin System Preference can be set to update the
>location of ALL items during check in, regardless of their shelving location.
>However, this does not currently work 100% as it is excluding items with no
>shelving location (i.e. value of NULL in the corresponding database field).
>
>This patch, based on the comment made by Nick Clemens, fixes that.
>
>Test plan (based on the original Bug Description by Andrew Fuerste-Henry):
>
>1) Have a shelving location CART
>2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes)
>3) Check in an item that has a shelving location, confirm it changes to CART
>4) Check in an item with a NULL shelving location, confirm it doesn't go to CART
>5) Apply this patch
>6) Repeat step 4): this time the item should move to the CART shelving location
>---
> C4/Circulation.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 89e2737f56..9f7fadcfd3 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2023,7 +2023,10 @@ sub AddReturn {
>         if (defined $update_loc_rules->{_ALL_}) {
>             if ($update_loc_rules->{_ALL_} eq '_PERM_') { $update_loc_rules->{_ALL_} = $item->permanent_location; }
>             if ($update_loc_rules->{_ALL_} eq '_BLANK_') { $update_loc_rules->{_ALL_} = ''; }
>-            if ( defined $item->location && $item->location ne $update_loc_rules->{_ALL_}) {
>+            if (
>+                ( defined $item->location && $item->location ne $update_loc_rules->{_ALL_}) ||
>+                (!defined $item->location && $update_loc_rules->{_ALL_} ne "")
>+               ) {
>                 $messages->{'ItemLocationUpdated'} = { from => $item->location, to => $update_loc_rules->{_ALL_} };
>                 $item->location($update_loc_rules->{_ALL_})->store({skip_record_index=>1});
>             }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28472: 122541 | 122547 | 122749 | 124989 | 125011 | 125012 | 125033 | 125034 | 125050