Attachment 122564 Details for Bug 22435 – Bug 22435: (QA follow-up) Fix test file and adjust test

[patch] Bug 22435: (QA follow-up) Fix test file and adjust test

Bug-22435-QA-follow-up-Fix-test-file-and-adjust-te.patch (text/plain), 1.64 KB, created by Tomás Cohen Arazi (tcohen) on 2021-07-02 15:33:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-07-02 15:33:09 UTC

Size: 1.64 KB

patch

obsolete

>From a9151a0932f8d2410227c47cfc46353d20b0e7e8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 18 Jun 2021 15:11:31 +0000
>Subject: [PATCH] Bug 22435: (QA follow-up) Fix test file and adjust test
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/Account/Line.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Account/Line.t b/t/db_dependent/Koha/Account/Line.t
>index ff0f924c0d..f3f65f5bdf 100755
>--- a/t/db_dependent/Koha/Account/Line.t
>+++ b/t/db_dependent/Koha/Account/Line.t
>@@ -220,7 +220,7 @@ subtest 'apply() tests' => sub {
>     is( $offsets->count, 1, 'Only one offset is generated' );
>     my $THE_offset = $offsets->next;
>     is( $THE_offset->amount * 1, -10, 'Amount was calculated correctly (less than the available credit)' );
>-    is( $THE_offset->type, 'Manual Credit', 'Passed type stored correctly' );
>+    is( $THE_offset->type, 'APPLY', 'Passed type stored correctly' );
> 
>     $debits = Koha::Account::Lines->search({ accountlines_id => $debit_2->id });
>     $credit = $credit->apply( { debits => [ $debits->as_list ] } );
>@@ -266,7 +266,7 @@ subtest 'apply() tests' => sub {
> 
>     $debits = Koha::Account::Lines->search({ accountlines_id => { -in => [ $debit_1->id, $debit_2->id, $debit_3->id, $credit->id ] } });
>     throws_ok {
>-        $credit_2->apply( { debits => [ $debits->as_list ] }
>+        $credit_2->apply( { debits => [ $debits->as_list ] }); }
>         'Koha::Exceptions::Account::IsNotDebit',
>         '->apply() rolls back if any of the passed lines is not a debit';
> 
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 22435: 118340 | 118341 | 118541 | 118542 | 118543 | 118544 | 118545 | 118546 | 118547 | 120040 | 120041 | 120042 | 120043 | 120044 | 120045 | 120046 | 120963 | 120964 | 120965 | 120966 | 120967 | 120968 | 120969 | 120970 | 120979 | 120980 | 120981 | 120982 | 120983 | 120984 | 120985 | 120986 | 120987 | 120988 | 120989 | 120990 | 120991 | 121004 | 121005 | 121006 | 121007 | 121008 | 121009 | 121010 | 121011 | 121012 | 121013 | 121014 | 121015 | 121016 | 121028 | 121757 | 121758 | 121759 | 121760 | 121761 | 121762 | 121763 | 121764 | 121765 | 121766 | 121767 | 121768 | 121769 | 121960 | 121961 | 121962 | 121963 | 121964 | 121965 | 121966 | 121967 | 121968 | 121969 | 121970 | 121971 | 121972 | 122148 | 122149 | 122150 | 122151 | 122152 | 122153 | 122154 | 122155 | 122156 | 122157 | 122158 | 122159 | 122160 | 122161 | 122235 | 122236 | 122237 | 122238 | 122239 | 122240 | 122241 | 122242 | 122243 | 122244 | 122245 | 122246 | 122247 | 122248 | 122249 | 122250 | 122251 | 122252 | 122253 | 122256 | 122257 | 122258 | 122259 | 122260 | 122261 | 122262 | 122263 | 122264 | 122265 | 122266 | 122267 | 122268 | 122269 | 122270 | 122271 | 122272 | 122273 | 122274 | 122553 | 122554 | 122555 | 122556 | 122557 | 122558 | 122559 | 122560 | 122561 | 122562 | 122563 | 122564 | 122565 | 122566 | 122567 | 122568 | 122569 | 122570 | 122571 | 122586 | 122899 | 122900 | 122901 | 122902 | 122903 | 122904 | 122905 | 122906 | 122907 | 122908 | 122909 | 122910 | 122911 | 122912 | 122913 | 122914 | 122915 | 122916 | 122917 | 122918 | 122937 | 123423 | 123424 | 123425 | 123426 | 123427 | 123428 | 123429 | 123430 | 123431 | 123432 | 123433 | 123434 | 123435 | 123436 | 123437 | 123438 | 123439 | 123440 | 123441 | 123442 | 123443