Attachment 122648 Details for Bug 28672 – Bug 28672: Pass itemnumber instead of item object

[patch] Bug 28672: Pass itemnumber instead of item object

Bug-28672-Pass-itemnumber-instead-of-item-object.patch (text/plain), 1.02 KB, created by Martin Renvoize (ashimema) on 2021-07-07 11:45:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-07-07 11:45:04 UTC

Size: 1.02 KB

patch

obsolete

>From c31eb241af1e707e5500d4d281a701c906964795 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 7 Jul 2021 12:43:36 +0100
>Subject: [PATCH] Bug 28672: Pass itemnumber instead of item object
>
>The warn call here was passing the full item object which leads to
>HASH() in the logs.. this patch updates it to pass the itemnumber which
>is more helpful.
>---
> Koha/EDI.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/EDI.pm b/Koha/EDI.pm
>index 5857f4eff7..799172efe1 100644
>--- a/Koha/EDI.pm
>+++ b/Koha/EDI.pm
>@@ -535,10 +535,10 @@ sub transfer_items {
>             $ilink->update;
>             --$quantity;
>             --$mapped_by_branch{$i_branch};
>-            $logger->warn("Transferred item $item");
>+            $logger->warn("Transferred item $item->itemnumber");
>         }
>         else {
>-            $logger->warn("Skipped item $item");
>+            $logger->warn("Skipped item $item->itemnumber");
>         }
>         if ( $quantity < 1 ) {
>             last;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28672: 122648 | 145931 | 145932 | 145933