Bugzilla – Attachment 122800 Details for
Bug 28704
Library MARCOrgCode field needs maxlength attribute
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28704: Library MARCOrgCode field needs maxlength attribute
Bug-28704-Library-MARCOrgCode-field-needs-maxlengt.patch (text/plain), 1.95 KB, created by
Owen Leonard
on 2021-07-13 11:21:16 UTC
(
hide
)
Description:
Bug 28704: Library MARCOrgCode field needs maxlength attribute
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-07-13 11:21:16 UTC
Size:
1.95 KB
patch
obsolete
>From cace7e551ac5e9d5d2778c64ee8417c1f92bb3c0 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 13 Jul 2021 10:54:59 +0000 >Subject: [PATCH] Bug 28704: Library MARCOrgCode field needs maxlength > attribute > >This patch adds a maxlength attribute to the "MARC organization code" >field in the form for adding and editing libraries. The maxlength, 16, >matches the limit of the table column. > >To reproduce the problem, go to Administration -> Libraries. > - Add or edit a library > - Fill the "MARC organization code" field with a string longer than 16 > characters, e.g. Decriminalization > - When you save the record you will see an error. > >Apply the patch and add or edit a library. > - Confirm that you cannot enter more than 16 characters in the "MARC > organization code" field. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index 38183a507a..01b2c0f455 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -243,7 +243,7 @@ Libraries › Administration › Koha > </li> > <li> > <label for="marcorgcode">MARC organization code</label> >- <input type="text" name="marcorgcode" id="marcorgcode" size="16" value="[% library.marcorgcode | html %]" /> >+ <input type="text" name="marcorgcode" id="marcorgcode" size="16" maxlength="16" value="[% library.marcorgcode | html %]" /> > <div class="hint"> > [% IF ( CAN_user_parameters_manage_sysprefs ) %] > If not filled in defaults to system preference <a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=MARCOrgCode">MARCOrgCode</a>. >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28704
:
122800
|
123288
|
123298