Bugzilla – Attachment 122850 Details for
Bug 22690
Merging records with many items too slow (Elasticsearch)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22690: (QA follow-up) Make bib-level hold object actually bib-level
Bug-22690-QA-follow-up-Make-bib-level-hold-object-.patch (text/plain), 1.15 KB, created by
Martin Renvoize (ashimema)
on 2021-07-15 09:31:22 UTC
(
hide
)
Description:
Bug 22690: (QA follow-up) Make bib-level hold object actually bib-level
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-07-15 09:31:22 UTC
Size:
1.15 KB
patch
obsolete
>From 5615b5b8837fd31b5ccaf0a60274ddaae1f2db6d Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Fri, 28 May 2021 13:57:53 +0300 >Subject: [PATCH] Bug 22690: (QA follow-up) Make bib-level hold object actually > bib-level > >We need to pass undef itemnumber to build_object() to actually have a >hold without an item tied to it. Otherwise build_object() will create >automatically an item for us (thus making it an item-level hold) > >To test: > $ prove t/db_dependent/Koha/Item.t > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Item.t | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index b4fbc5341f..81d39baf81 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -927,6 +927,7 @@ subtest 'move_to_biblio() tests' => sub { > class => 'Koha::Holds', > value => { > biblionumber => $source_biblionumber, >+ itemnumber => undef, > }, > }); > my $item_level_hold1 = $builder->build_object({ >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22690
:
90061
|
90115
|
90116
|
92828
|
94505
|
97696
|
98143
|
98210
|
98211
|
99376
|
99379
|
100316
|
104796
|
104797
|
104871
|
105445
|
106144
|
108777
|
109694
|
110991
|
110994
|
111196
|
111207
|
111236
|
111237
|
112100
|
112184
|
112567
|
112569
|
112754
|
113308
|
113309
|
113941
|
113942
|
113967
|
113968
|
118226
|
118227
|
118229
|
118231
|
118391
|
119433
|
119434
|
120820
|
120821
|
120852
|
120853
|
121389
|
121392
|
121474
|
121516
|
121517
|
121518
|
121519
|
121520
|
122846
|
122847
|
122848
|
122849
|
122850
|
122886
|
122887
|
122888
|
122889
|
122890
|
122936
|
122938
|
122939
|
123029
|
123030
|
123031
|
123032
|
123033
|
123034
|
123035
|
123036
|
123037
|
123038
|
123039
|
123040
|
123041
|
123042
|
123044
|
123062
|
123481
|
123482
|
123483
|
123484
|
123485
|
123486
|
123487
|
123488
|
123489
|
123490
|
123491
|
123492
|
123493
|
123494
|
123495
|
123496
|
123497
|
124176
|
124188
|
124257