Bugzilla – Attachment 122859 Details for
Bug 28690
Important and mandatory not checked on all item forms
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28689: Extra %s in alert message when saving an items
Bug-28689-Extra-s-in-alert-message-when-saving-an-.patch (text/plain), 1.60 KB, created by
Owen Leonard
on 2021-07-15 13:10:15 UTC
(
hide
)
Description:
Bug 28689: Extra %s in alert message when saving an items
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-07-15 13:10:15 UTC
Size:
1.60 KB
patch
obsolete
>From 75dacad4874d82adc9c226eaa6b2dbbf95df4114 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 15 Jul 2021 13:00:14 +0000 >Subject: [PATCH] Bug 28689: Extra %s in alert message when saving an items > >This patch removes an unnecessary %s in the text built to show when >there are errors in the cataloging add item form. > >To reproduce, open the add item form in cataloging and click "Add item" >without filling in all mandatory fields. You should see an alert message >that contains, "- %s 1 mandatory fields empty (highlighted)" > >To test, apply the patch and return to the add item form. Now when you >save an incomplete form the message should omit the %s: > >- 1 mandatory fields empty (highlighted) > >https://bugs.koha-community.org/show_bug.cgi?id=28690 >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >index 22badd189d..cb841c3e3c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >@@ -86,7 +86,7 @@ function Check(f) { > } else { > alertString2 = MSG_FORM_NOT_SUBMITTED; > alertString2 += "\n------------------------------------------------------------------------------------\n"; >- alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_mandatory); >+ alertString2 += "\n- " + MSG_MANDATORY_FIELDS_EMPTY.format(total_mandatory); > } > if(total_important > 0){ > if( !alertString2 ){ >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28690
:
122859