Attachment 122866 Details for Bug 28631 – Bug 28631: Holds History title link returns "not found" error

[patch] Bug 28631: Holds History title link returns "not found" error

Bug-28631-Holds-History-title-link-returns-not-fou.patch (text/plain), 3.12 KB, created by Marcel de Rooy on 2021-07-16 06:28:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-07-16 06:28:36 UTC

Size: 3.12 KB

patch

obsolete

>From c021d70550d605a9f784c741dfb46580e13c64ad Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 30 Jun 2021 15:42:50 +0000
>Subject: [PATCH] Bug 28631: Holds History title link returns "not found" error
>Content-Type: text/plain; charset=utf-8
>
>This patch corrects a broken path in the OPAC holds history page.
>
>This patch also corrects the breadcrumb markup which didn't conform to
>the new Bootstrap 4 pattern.
>
>To test, apply the patch and log into the OPAC as a patron who has past
>or current holds.
>
>- View the "your holds history" page.
>- Click a title link in the table of holds. It should take you to the
>  correct bibliographic detail page.
>- Check the breadcrumbs of the page. They should look consistent with
>  breadcrumb navigation on other pages in the OPAC.
>
>Signed-off-by: Kelly <kelly@bywatersolutions.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../bootstrap/en/modules/opac-holdshistory.tt | 20 +++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>index 01e409b45e..caa13006ac 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
>@@ -38,11 +38,19 @@
> [% INCLUDE 'masthead.inc' %]
> 
> <div class="main">
>-    <ul class="breadcrumb">
>-        <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">&rsaquo;</span></li>
>-        <li><a href="/cgi-bin/koha/opac-user.pl">[% INCLUDE 'patron-title.inc' patron = logged_in_user %]</a> <span class="divider">&rsaquo;</span></li>
>-        <li><a href="#">Your holds history</a></li>
>-    </ul>
>+    <nav aria-label="breadcrumb">
>+        <ul class="breadcrumb">
>+            <li class="breadcrumb-item">
>+                <a href="/cgi-bin/koha/opac-main.pl">Home</a>
>+            </li>
>+            <li class="breadcrumb-item">
>+                <a href="/cgi-bin/koha/opac-user.pl">[% INCLUDE 'patron-title.inc' patron = logged_in_user %]</a>
>+            </li>
>+            <li class="breadcrumb-item" aria-current="page">
>+                <a href="#">Your holds history</a>
>+            </li>
>+        </ul>
>+    </nav>
> 
>     <div class="container-fluid">
>         <div class="row">
>@@ -104,7 +112,7 @@
>                                     <tbody>
>                                     [% FOREACH hold IN holds %]
>                                         <tr>
>-                                        <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% hold.biblio.biblionumber | uri %]">[% INCLUDE 'biblio-title.inc' biblio=hold.biblio %]</a></td>
>+                                        <td><a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% hold.biblio.biblionumber | uri %]">[% INCLUDE 'biblio-title.inc' biblio=hold.biblio %]</a></td>
>                                         <td>[% hold.biblio.author | html %]</td>
>                                         <td>[% hold.item.barcode | html %]</td>
>                                         <td>[% Branches.GetName( hold.branchcode ) | html %]</td>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28631: 122510 | 122755 | 122866