Bugzilla – Attachment 122951 Details for
Bug 27526
Remove Mod/AddItemFromMarc from additem.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27526: Fix mandatory and important checks
Bug-27526-Fix-mandatory-and-important-checks.patch (text/plain), 1.95 KB, created by
Jonathan Druart
on 2021-07-19 14:50:59 UTC
(
hide
)
Description:
Bug 27526: Fix mandatory and important checks
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-07-19 14:50:59 UTC
Size:
1.95 KB
patch
obsolete
>From 1cc3e20074af94a23e47752c809499e00f52a0a4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jul 2021 15:48:36 +0200 >Subject: [PATCH] Bug 27526: Fix mandatory and important checks > >The input names have been changed from "field_value" to $kohafield. >Modifying this could have an impact in other area, where >CheckMandatorySubfields and CheckImportantSubfields are called. >Using .input_marceditor let us fix the additem.tt form and prevent to >break the other ones. >Note that the other ones are actually broken (!) > >Also note that there is a typo in the error message > alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); >There is an extra %s > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index 2dc65396ad6..60b0ff5b81b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -556,7 +556,7 @@ function CloneItemSubfield(original){ > function CheckMandatorySubfields(p){ > var total = 0; > $(p).find(".subfield_line input[name='mandatory'][value='1']").each(function(){ >- var editor = $(this).siblings("[name='field_value']"); >+ var editor = $(this).siblings(".input_marceditor"); > if (!editor.val()) { > editor.addClass("missing"); > total++; >@@ -568,7 +568,7 @@ function CheckMandatorySubfields(p){ > function CheckImportantSubfields(p){ > var total = 0; > $(p).find(".subfield_line input[name='important'][value='1']").each(function(i){ >- var editor = $(this).siblings("[name='field_value']"); >+ var editor = $(this).siblings(".input_marceditor"); > if (!editor.val()) { > editor.addClass("missing"); > total++; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27526
:
115679
|
115680
|
116006
|
117806
|
117807
|
117808
|
121589
|
121590
|
121591
|
122288
|
122318
|
122655
|
122656
|
122657
|
122658
|
122676
|
122677
|
122681
|
122682
|
122694
|
122695
|
122696
|
122946
|
122947
|
122948
|
122949
|
122950
|
122951
|
122952
|
122953
|
122954
|
122957
|
122958
|
122959
|
122974
|
123006
|
123007
|
123110
|
123329
|
123372
|
123415
|
123757
|
123758
|
123759
|
123760
|
123761
|
123762
|
123763
|
123764
|
123765
|
123766
|
123767
|
123768
|
123769
|
123770
|
123771
|
123772
|
125069
|
125605
|
125606
|
125607
|
125608
|
125609
|
125610
|
125611
|
125612
|
125613
|
125614
|
125615
|
125616
|
125617
|
125618
|
125619
|
125620
|
125818
|
125839
|
125863
|
126034
|
126051
|
126143
|
126144
|
126393
|
127025
|
127032