Bugzilla – Attachment 122959 Details for
Bug 27526
Remove Mod/AddItemFromMarc from additem.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27526: Fix empty string vs undef
Bug-27526-Fix-empty-string-vs-undef.patch (text/plain), 1.09 KB, created by
Jonathan Druart
on 2021-07-20 10:26:06 UTC
(
hide
)
Description:
Bug 27526: Fix empty string vs undef
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-07-20 10:26:06 UTC
Size:
1.09 KB
patch
obsolete
>From bb561c72641e84f040864f3c4a62c13e9d453408 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 20 Jul 2021 12:09:55 +0200 >Subject: [PATCH] Bug 27526: Fix empty string vs undef > >Empty strings must be removed, not inserted as empty strings in DB. >The relevant code is in TransformHtmlToXml, $skip variable. >--- > cataloguing/additem.pl | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 85b03da86e8..9150ad2b785 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -449,9 +449,13 @@ if ($op eq "additem") { > } > $item->more_subfields_xml(undef); > } else { >- my @v = $input->multi_param("items.".$c); >- next unless @v; >- $item->$c(join ' | ', uniq @v); >+ my @v = grep { $_ ne "" } >+ uniq $input->multi_param( "items." . $c ); >+ >+ next if !@v >+ && $c ne 'permanent_location'; # See 27837 >+ >+ $item->$c(join ' | ', @v); > } > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27526
:
115679
|
115680
|
116006
|
117806
|
117807
|
117808
|
121589
|
121590
|
121591
|
122288
|
122318
|
122655
|
122656
|
122657
|
122658
|
122676
|
122677
|
122681
|
122682
|
122694
|
122695
|
122696
|
122946
|
122947
|
122948
|
122949
|
122950
|
122951
|
122952
|
122953
|
122954
|
122957
|
122958
|
122959
|
122974
|
123006
|
123007
|
123110
|
123329
|
123372
|
123415
|
123757
|
123758
|
123759
|
123760
|
123761
|
123762
|
123763
|
123764
|
123765
|
123766
|
123767
|
123768
|
123769
|
123770
|
123771
|
123772
|
125069
|
125605
|
125606
|
125607
|
125608
|
125609
|
125610
|
125611
|
125612
|
125613
|
125614
|
125615
|
125616
|
125617
|
125618
|
125619
|
125620
|
125818
|
125839
|
125863
|
126034
|
126051
|
126143
|
126144
|
126393
|
127025
|
127032