Attachment 123075 Details for Bug 25260 – Bug 25260: Sane TestBuilder defaults

[patch] Bug 25260: Sane TestBuilder defaults

Bug-25260-Sane-TestBuilder-defaults.patch (text/plain), 1.14 KB, created by Tomás Cohen Arazi (tcohen) on 2021-07-23 04:04:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-07-23 04:04:30 UTC

Size: 1.14 KB

patch

obsolete

>From 73e435f7aed7ec838cc5c98b1451859a3ad28d6b Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 6 Jan 2021 11:31:30 -0300
>Subject: [PATCH] Bug 25260: Sane TestBuilder defaults
>
>This patch sets some sane defaults for TestBuilder.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/lib/TestBuilder.pm | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
>index e8b0dbf126..851a1bcfd2 100644
>--- a/t/lib/TestBuilder.pm
>+++ b/t/lib/TestBuilder.pm
>@@ -574,8 +574,16 @@ sub _gen_default_values {
>         Branch => {
>             pickup_location => 0,
>         },
>-        Reserve => {
>-            non_priority => 0,
>+        Hold => {
>+            non_priority    => 0,
>+            completed       => 0,
>+            completed_date  => undef,
>+            waiting_date    => undef,
>+            item_level      => 0,
>+            lowest_priority => 0,
>+            suspended       => 0,
>+            suspended_until => undef,
>+            expiration_date => undef,
>         },
>         Itemtype => {
>             rentalcharge => 0,
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 25260: 103984 | 103985 | 103986 | 103987 | 103988 | 103989 | 103990 | 103991 | 103992 | 103993 | 104053 | 104054 | 104055 | 104056 | 104057 | 117745 | 117746 | 117747 | 117748 | 117749 | 117750 | 117751 | 122761 | 122762 | 122763 | 122764 | 122765 | 122766 | 122767 | 122787 | 122788 | 122789 | 122790 | 122791 | 122792 | 122793 | 122976 | 122977 | 122978 | 122979 | 122980 | 122981 | 122982 | 122983 | 123071 | 123072 | 123073 | 123074 | 123075 | 123076 | 123077 | 123078 | 123079 | 123080 | 123257 | 123258 | 123259 | 123260 | 123261 | 123396